Use new template repo #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staverm
approved these changes
Jan 6, 2026
Member
staverm
left a comment
staverm
left a comment
There was a problem hiding this comment.
Agent impls look good. Both scenarios run smoothly on my machine. I'm on board for getting these in but I'm not sure what to do with the old code.
We can either delete it or leave it as alternative impls, but then it would be good to mention that in some README. Keeping alternative impls seems fine for a tutorial repo. What do you think?
Talking about these files:
Tau2
- tau2/tau2_agent.py
- tau2/tau2_evaluator.py
Debate
- debate/debater.py
- debate/debate_judge_common.py
- debate/debate_judge.py
- debate/adk_debate_judge.py
- debate/Dockerfile.adk-debate-judge
we can e.g. add a debate/README file and briefly explain the different impls
The old 'SDK'
- src/agentbeats/green_executor.py
- src/agentbeats/tool_provider.py
it's weird that this is shared code, but the new template Executor is not
| json.dump(output_data, f, indent=2) | ||
| print(f"Results written to {output_path}") | ||
|
|
||
| if error_status: |
Member
There was a problem hiding this comment.
ℹ️ this change is to write the output json file even when green agent fails (writes role-id mapping and empty results)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.