Skip to content

Update js #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hlageek merged 6 commits into from
Nov 10, 2025
+15 −7
Merged

Update js #175

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
26e1a5b
Update JS for coding segments
skvrnami Oct 19, 2025
b410e68
Update description
skvrnami Oct 20, 2025
61154dd
update selection only on annotation page
skvrnami Oct 29, 2025
cbf424c
Revert "update selection only on annotation page"
hlageek Oct 29, 2025
dd99d16
reduce listener scope to element
hlageek Oct 29, 2025
04c4fbc
make article tabable
hlageek Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions inst/app/www/document_code_js.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,8 @@ function getCaretCharacterOffsetWithin(element) {
return caretOffset;
}

// Function to send calculated positions to Shiny
$( document ).ready(function() {
document.addEventListener('mouseup', function () {
var sel = window.getSelection();
function updateSelection() {
var sel = window.getSelection();
// if(window.getSelection().baseNode.parentNode.id != "document_code_ui_1-focal_text") return;

if(sel.rangeCount > 0){
Expand Down Expand Up @@ -68,8 +66,15 @@ document.addEventListener('mouseup', function () {
console.log("tag_position" + tag_position_value)
Shiny.setInputValue('document_code_ui_1-tag_position', tag_position_value);
}
}, false);
}

// Function to send calculated positions to Shiny
$( document ).ready(function() {
document.addEventListener('mouseup', updateSelection);
document.addEventListener('keyup', updateSelection);
Copy link
Contributor

@hlageek hlageek Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyup tady není moc dobrej, volá tu funkci furt, i když třeba píšeš jméno kódu v jiným tabu
asi něco jako $('#document_code_ui_1-focal_text').on('mouseup keyup touchend', updateSelection); bude lepší?

Copy link
Contributor Author

@skvrnami skvrnami Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hlageek check it out now

document.addEventListener('touchend', updateSelection);
})

// Obtain information from iframe and send to Shiny
$(document).ready(function() {
var iframe = document.getElementsByTagName('iframe')[0];
Expand Down