-
Notifications
You must be signed in to change notification settings - Fork 1
node-can-bridge: Add support for Linux and macOS #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
qwertychouskie
wants to merge
35
commits into
REVrobotics:main
Choose a base branch
from
unofficial-rev-port:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 26 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
b0ca096
add serialdriver for other platforms then windows
Moose1301 5d0a1a5
macOS: Compilation now succeeds, linking still fails though
qwertychouskie 7362fe8
Manifest GitHub Actions workflows
garrettsummerfi3ld 7278259
build.yml: Install distutils
qwertychouskie c58a3fd
build.yml: Disable caching `pip` (unbreak build)
qwertychouskie 439c5d0
release.yml: Install distutils
qwertychouskie 92e225f
release.yml: Fix action name
qwertychouskie c67db7f
Disable job cancel on build failure
garrettsummerfi3ld b54a763
Fix CI release job on every push to `main`
garrettsummerfi3ld ab1a3c9
Partial revert of commit `c67db7fbf74d82e71682f62f6f5a8477df2cdc66`
garrettsummerfi3ld b68b454
Merge pull request #1 from unofficial-rev-port/ci/setup
garrettsummerfi3ld 45ab8d8
Update download-CanBridge.mjs
garrettsummerfi3ld 50943a3
Major refactor for handling CANBridge
garrettsummerfi3ld 3929fbd
Fix multiarch movement for CANBridge
garrettsummerfi3ld b609d96
Add macOS and Linux platforms
garrettsummerfi3ld 5115898
Enable exception handling to allow Linux compilation
garrettsummerfi3ld 70988aa
Unbreak macOS arm64 build
qwertychouskie 7526628
Fix some warnings
qwertychouskie 4b14281
Partial fix for Windows build regression
garrettsummerfi3ld 8230825
chore: Bump CANBridge tag
garrettsummerfi3ld c67f0e3
fix: Reimplement stopHeartbeats function to fix MSVC builds
garrettsummerfi3ld 3f673e6
binding.gyp: Change `darwin-x64` to `darwin-osxuniversal`
qwertychouskie 90e8926
chore: Bump CANBridge tag
garrettsummerfi3ld 5140afc
chore: Update build workflow to include pretest step
garrettsummerfi3ld 79ab7e6
Update `README.md`
garrettsummerfi3ld 5712827
Fix exceptions on macOS
qwertychouskie c9232a4
chore: Update npm dependencies
garrettsummerfi3ld 955f5e9
Merge pull request #5 from unofficial-rev-port/sanity/node-gyp
garrettsummerfi3ld 9a442f4
ci: Remove `setuptools` step
garrettsummerfi3ld 822a510
Revert changes made to `canWrapper.cc`
garrettsummerfi3ld 1f84037
Merge pull request #6 from unofficial-rev-port/ci/setuptools-removal
garrettsummerfi3ld 9827e48
[ci skip] chore: Rename release workflow job
garrettsummerfi3ld a0152c2
Merge remote-tracking branch 'upstream/main'
qwertychouskie 0ef46b6
Remove `CanBridgeInitializationError` custom error
qwertychouskie cb581d3
Merge pull request #8 from unofficial-rev-port/fix/canwrapper
garrettsummerfi3ld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
name: Build | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
pull_request: | ||
branches: | ||
- '*' | ||
|
||
jobs: | ||
build: | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: [ubuntu-latest, windows-latest, macos-latest] | ||
runs-on: ${{ matrix.os }} | ||
name: "Build - ${{ matrix.os }}" | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Set up Node.js | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: '20' | ||
|
||
- uses: actions/setup-python@v5 | ||
with: | ||
python-version: '3.10' | ||
|
||
- name: Install Python setup tools | ||
run: | | ||
pip install setuptools | ||
|
||
- name: Install dependencies | ||
run: npm install | ||
|
||
- name: Pretest | ||
run: npm run pretest | ||
|
||
- name: Test | ||
run: npm test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
name: Release | ||
|
||
on: | ||
push: | ||
tags: | ||
- 'v*' | ||
|
||
jobs: | ||
build: | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: [ubuntu-latest, windows-latest, macos-latest] | ||
runs-on: ${{ matrix.os }} | ||
name: "Release - ${{ matrix.os }}" | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Set up Node.js | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: '20' | ||
|
||
- uses: actions/setup-python@v5 | ||
with: | ||
python-version: '3.10' | ||
- name: Install Python setup tools | ||
run: | | ||
pip install setuptools | ||
|
||
- name: Install dependencies | ||
run: npm install | ||
|
||
- name: Build | ||
run: npm run build | ||
|
||
- name: Create release | ||
uses: softprops/action-gh-release@v2 | ||
with: | ||
files: dist/* | ||
tag_name: ${{ github.ref }} | ||
name: ${{ github.ref }} | ||
body: | | ||
This is a release for version ${{ github.ref }}. | ||
It contains the compiled files from the build process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.