-
Notifications
You must be signed in to change notification settings - Fork 8
fix: new ui fixes-report & repository tables #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
424ffbf
chore: add mocks and pagination to repository table
rhartuv b0fc5ae
feat: add filtering component and filter by EIQ stat to repository table
rhartuv 246fa98
fix: add all statuses to CVE Status Summary pie chart
rhartuv 1554a43
feat: add filter by exploitIQ Status to /reports API backend
rhartuv b0cbbc4
style: add colors to scan state label on repository table
rhartuv 9af0d16
style: change state location on reportPage title
rhartuv 4b8d0c3
feat: add sort to repository table
rhartuv 0395dc8
style: change expired color on Repository analysis distribution
rhartuv 632a4eb
fix
rhartuv 3a2c4e3
chore: add sorting to the server side
rhartuv d8f6975
chore: add table empty state to all the tables
rhartuv ffb9adb
chore: change sort and filter fields on repository table and add link…
rhartuv 912adc2
fix
rhartuv 8eb7555
chore: apply default sorting by analysis state
rhartuv 22340d2
fix: toolbar remains visible during loading&handle multiple filters v…
rhartuv 55d0fd5
style: page header changes
rhartuv 1282624
chore:add skeleton to home page
rhartuv eabe972
style: update index.html icon and name
rhartuv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sorting for "state" exists because state is computed from multiple fields (not stored) so MongoDB can't sort by it directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it's not possible we should not enable it
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no state field, it is calculated when reading from the fields:
error.type → "expired"/ "failed"
input.scan.completed_at → "completed"
metadata.sent_at → "sent"
metadata.submitted_at → "queued"
metadata.product_id → "pending"
Therefore, sorting by "state" requires mapping to these fields.
I added this because it appears in both the old UI and FIGMA.