feat: migrate to TanStack Query#132
feat: migrate to TanStack Query#132r2dedios merged 4 commits intoRHEcosystemAppEng:release-0.5.1from
Conversation
Signed-off-by: Vladimir Belousov <vbelouso@redhat.com>
Signed-off-by: Vladimir Belousov <vbelouso@redhat.com>
Signed-off-by: Vladimir Belousov <vbelouso@redhat.com>
vbelouso
force-pushed
the
feat/tanstack-query
branch
from
4a5707c to
6c0d88c
Compare
Signed-off-by: Vladimir Belousov <vbelouso@redhat.com>
| return useQuery<InstanceResponseApi[]>({ | ||
| queryKey: ['instances'], | ||
| queryFn: async ({ signal }) => { | ||
| const { data } = await api.instances.instancesList({ page: 1, page_size: 100000 }, { signal }); |
There was a problem hiding this comment.
I'm wondering if asking for 100.000 instances every time we access to that info it's overloading the API
There was a problem hiding this comment.
In client-side filtering, we either get everything at once or switch to side filtering. Due to caching this data is requested only once. If we increase the data refresh time more than 5 minutes(as it is now) the API will have a minimum of requests.
Click between pages in the UI and you'll see that the request is made only once.
| import { api, SystemEventResponseApi } from '@api'; | ||
|
|
||
| export function useEvents() { | ||
| return useQuery<SystemEventResponseApi[]>({ |
There was a problem hiding this comment.
Does make sense to include refetchInverval on this functions to maintain data updated?
There was a problem hiding this comment.
I'm not sure. What might this be needed for?
|
Is it possible to remove this icon? 
** Correction: ** It only appears in development env. Not when running the container image |
Yes, appears in dev mode only for debugging |
2 participants
No description provided.