Skip to content

Conversation

@vbelouso
Copy link
Collaborator

@vbelouso vbelouso commented Jan 15, 2026

Fixes a bug where the Ecosystem enum member was being stringified directly into the SerpApi search query (e.g. Ecosystem.GO), instead of using its value (go).

This resulted in malformed search queries that could reduce search result quality.

Before: Query contained part+of+the+Ecosystem.GO+standard+library, which is not natural language.
After: Query contains part+of+the+go+standard+library.

Example of issue (from logs):

[09/Jan/2026:13:39:52 +0000] traceId: - - (MISS) "GET /serpapi/search?engine=google&google_domain=google.com&gl=us&hl=en&api_key=FAKE&q=Is+'github.com/golang/crypto/jwt'+part+of+the+Ecosystem.GO+standard+library?&source=python&serp_api_key=FAKE&output=json HTTP/1.1" 401 - 108 bytes {10.130.3.188} "Python/3.12 aiohttp/3.12.15" 0.032 - 1. Auth: [NOT PROVIDED]
2026/01/09 13:39:52 [info] 77#77: *53 client 10.130.3.188 closed keepalive connection

@vbelouso vbelouso self-assigned this Jan 15, 2026
@vbelouso vbelouso added the bug Something isn't working label Jan 15, 2026
@vbelouso vbelouso requested a review from zvigrinberg January 15, 2026 16:18
Copy link
Collaborator

@zvigrinberg zvigrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbelouso Good catch!
Approved.

@vbelouso vbelouso merged commit 7ece473 into RHEcosystemAppEng:main Jan 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants