Skip to content

Skip needed_rules controls in rule-identifiers reference validation #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arden97 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip needed_rules controls in rule-identifiers reference validation #541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions static-checks/rule-identifiers/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,23 @@

# Parse from datastream all rules and all their references
rule_references = defaultdict(set)
# Collect stigid text values
rule_stigid_text = {}

for frames, elements in oscap.parse_xml(util.get_datastream()):
if len(frames) < 3 or frames[-3:] != ['Group', 'Rule', 'reference']:
continue

rule, reference = elements[-2:]
rule = rule.get('id').removeprefix('xccdf_org.ssgproject.content_rule_')
reference = reference.get('href')
rule_references[rule].add(reference)
rule_id = rule.get('id').removeprefix('xccdf_org.ssgproject.content_rule_')
ref_href = reference.get('href')
ref_text = reference.text

rule_references[rule_id].add(ref_href)

# Store the control ID
if ref_text and 'stigs/downloads' in ref_href:
rule_stigid_text[rule_id] = ref_text

for ref_profile, nested in profile_references.items():
if ref_profile not in profiles:
Expand All @@ -64,6 +73,10 @@

for ref_name, ref_url in nested.items():
for rule in profiles[ref_profile].rules:
# Skip rules from 'needed_rules' controls - they don't have actual requirement IDs
if rule in rule_stigid_text and rule_stigid_text[rule] == 'needed_rules':
continue

result_name = f'{ref_profile}/{ref_name}/{rule}'
if ref_url in rule_references[rule]:
results.report('pass', result_name)
Expand Down