Skip to content

Conversation

@chrysn
Copy link
Member

@chrysn chrysn commented Nov 2, 2025

Contribution description

With latest c2rust, errors like this pop up:

  C2Rust binary c2rust, version: C2Rust 0.21.0
  Running C2Rust on /home/maribu/Repos/software/RIOT/master/examples/lang_support/official/rust-async/bin/nrf52840dk/target/thumbv7em-none-eabihf/release/build/riot-sys-f95b102612df3fee/out/compile_commands.json
  cargo:warning=C2Rust failed with error code exit status: 2, exiting

  --- stderr
  error: The argument '--translate-const-macros <TRANSLATE_CONST_MACROS>' requires a value but none was supplied
  	[possible values: none, conservative, experimental]

This pulls in RIOT-OS/rust-riot-sys#60 where the c2rust invocation in riot-sys has been updated, and (as that, by virtue of updating bindgen, updates some dependencies already) then also updates the rest of the compatible crates.

Testing procedure

Build testing is usually sufficient for this kind of update.

This pulls several other updates due to updated riot-sys dependencies.
Noteworthy updates are the riot-module-exampels that now use portable
atomics, updates to CoAP resource implementations, updated CBOR
implementations, and the removal of several Windows related transitive
dependencies.
@github-actions github-actions bot added Area: tests Area: tests and testing framework Area: sys Area: System Area: examples Area: Example Applications labels Nov 2, 2025
@chrysn chrysn added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Area: Rust Area: Rust wrapper and removed Area: tests Area: tests and testing framework Area: sys Area: System Area: examples Area: Example Applications labels Nov 2, 2025
@chrysn chrysn requested a review from maribu November 2, 2025 22:25
@maribu maribu enabled auto-merge November 2, 2025 22:26
@crasbe crasbe added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Nov 2, 2025
@riot-ci
Copy link

riot-ci commented Nov 2, 2025

Murdock results

FAILED

00328bf examples/rust-async: Block native32 due to unclear build issues

Build failures (6)
Application Target Toolchain Runtime (s) Worker
examples/lang_support/official/rust-hello-world native32 llvm 17.96 mobi6
examples/lang_support/official/rust-hello-world native32 gnu 24.03 mobi7
tests/rust_libs native32 llvm 22.70 mobi6
tests/rust_libs native32 gnu 23.98 mobi6
tests/rust_minimal native32 gnu 23.87 mobi6
tests/rust_minimal native32 llvm 23.76 mobi6

Artifacts

@github-actions github-actions bot added Area: tests Area: tests and testing framework Area: sys Area: System Area: examples Area: Example Applications labels Nov 3, 2025
@crasbe crasbe added CI: no fast fail don't abort PR build after first error CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 3, 2025
@crasbe crasbe added the State: needs rebase State: The codebase was changed since the creation of the PR, making a rebase necessary label Nov 11, 2025
@Teufelchen1
Copy link
Contributor

Rebased it locally and did some buildtests. Seems to work without issues. :)

@maribu
Copy link
Member

maribu commented Nov 14, 2025

I think this has the "allow edits from maintainers" flag set. Maybe you can push and see if Murdock now agrees?

@crasbe crasbe disabled auto-merge November 14, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: examples Area: Example Applications Area: Rust Area: Rust wrapper Area: sys Area: System Area: tests Area: tests and testing framework CI: no fast fail don't abort PR build after first error CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR State: needs rebase State: The codebase was changed since the creation of the PR, making a rebase necessary Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants