-
Notifications
You must be signed in to change notification settings - Fork 2.1k
sys/shell: add shell wrapper for openthread cli #21862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
sys/shell: add shell wrapper for openthread cli #21862
Conversation
Until now OpenThread CLI and RIOT shell could not be used at the same time. Now it is possible to use all CLI command with the prefix "ot". To get an overview use "ot help".
Automatically use RIOT shell when compiling OpenThread with CLI module. Ordered Makefile.dep alpha numerically.
Add shell to example, update readme and add adafruit-feather-sense to whitelisted boards, after testing.
eaa1033 to
c04fbd3
Compare
|
Fixed some errors that were created while doing the cleanup and tested for different boards now. PR is now ready for review. I changed the CLI transport from UART to Console and it works, but I'm not sure if this is correct. At least for the feather it is now possible to easily use the example, because previously the output was only available using a UART to USB adapter. |
mguetschow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, thank you! Haven't tested it yet, but I do have some comments already :)
bf9f69d to
07a0125
Compare
|
Tested to work nicely on an |
8abe2f0 to
61e1f85
Compare
mguetschow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bearing with me :) Looks good, please squash!
Contribution description
Adds a wrapper, so that the OpenThread CLI can be used through the RIOT shell. Without this, it was not possible to use the OpenThread CLI and RIOT shell capabilities simultaneously, as far as I am aware. To solve this, I created a new shell pseudo-module that adds the "ot" command, to provide access to the OpenThread CLI. If the openthread-cli-% module is used, the shell module will be compiled as a dependency. The OpenThread example previously made use of the OpenThread CLI, therefor the example has been adapted for the new usage.
Testing procedure
Tested shell and basic OpenThread utility with new wrapper for nrf52840dk, adafruit-feather-nrf52840-sense (added this to example whitelist) and frdm-kw41z.