Skip to content

pkg, boards & examples: fix static tests warnings - #22671

Open
krzysztof-cabaj wants to merge 94 commits into
RIOT-OS:masterfrom
krzysztof-cabaj:static-tests-pkg-dir
Open

pkg, boards & examples: fix static tests warnings#22671
krzysztof-cabaj wants to merge 94 commits into
RIOT-OS:masterfrom
krzysztof-cabaj:static-tests-pkg-dir

Conversation

@krzysztof-cabaj

@krzysztof-cabaj krzysztof-cabaj commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Contribution description

This PR fix warnings from static tests in pkg directory and some remaining in boards and examples directories.
This is continuation of works tracked by Issue #22216 .

Testing procedure

Green Murdock and greatly reduced number of static tests warnings concerning pkg, boards and examples directories.

Issues/PRs references

Tracking #22216

Declaration of AI-Tools / LLMs usage:

AI-Tools / LLMs that were used are:

  • none

@github-actions github-actions Bot added Area: network Area: Networking Area: pkg Area: External package ports Area: BLE Area: Bluetooth Low Energy support Area: LoRa Area: LoRa radio support Area: boards Area: Board ports Area: examples Area: Example Applications labels Sep 8, 2026
@crasbe crasbe added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR AI: Not Used AI was stated to not be used in this PR/Issue labels Sep 8, 2026
@riot-ci

riot-ci commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Murdock results

✔️ PASSED

608c1df fix: fix lv_conf.h

Success Failures Total Runtime
11293 0 11293 14m:16s

Artifacts

crasbe
crasbe reviewed Sep 8, 2026
View reviewed changes

@crasbe crasbe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review round, I have to go through it again later.

Comment thread examples/networking/dtls/dtls-echo/main.c Outdated
Comment thread examples/networking/dtls/dtls-wolfssl/main.c Outdated
Comment thread pkg/lvgl/include/lv_conf.h Outdated
Comment thread pkg/lvgl/include/lv_conf.h Outdated
Comment thread pkg/lvgl/include/lv_conf.h Outdated
Comment thread pkg/openthread/contrib/platform_settings.c Outdated
Comment thread pkg/openthread/include/ot.h Outdated
Comment thread pkg/wakaama/contrib/objects/security.c Outdated
Comment thread pkg/wakaama/include/objects/ipso_sensor_base.h Outdated
Comment thread pkg/wolfssl/sock_tls/sock_tls.h Outdated
@crasbe crasbe added the CI: no fast fail don't abort PR build after first error label Sep 8, 2026
@crasbe

crasbe commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Please try to avoid force-pushing and squash the commits only at the end, otherwise it'll be very hard to keep track of the changes.

@crasbe crasbe added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Sep 8, 2026
krzysztof-cabaj and others added 5 commits September 8, 2026 12:30
@krzysztof-cabaj @crasbe
Update examples/networking/dtls/dtls-echo/main.c
8e8e423 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update examples/networking/dtls/dtls-wolfssl/main.c
ef81fe8 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
4abaf9b 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
635527c 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
e352209 
Co-authored-by: crasbe <crasbe@gmail.com>
krzysztof-cabaj and others added 28 commits September 8, 2026 17:12
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
e1ade27 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
42d4206 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
c3b2bb0 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
bb784c3 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
e1be26b 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
6d9eacb 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
2af9de1 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
be3e1b0 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
6f99856 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
f37d69b 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
ea9fe22 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
5d45ec4 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
ab590ed 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
6d9a0cd 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
06389e7 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
e3d7930 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
4d033ed 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
93508ac 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
263c85b 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
41b3f3d 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
061e1f7 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
d84d141 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
d582b5e 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
4d43e9d 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
61bf6e7 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
9ffa148 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj @crasbe
Update pkg/lvgl/include/lv_conf.h
ffcf1fd 
Co-authored-by: crasbe <crasbe@gmail.com>
@krzysztof-cabaj
fix: fix lv_conf.h
608c1df
@krzysztof-cabaj

krzysztof-cabaj commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Second round of review fixed.

I have on question concerning convention for ending multi line comments with */ - when it should be at the end of line and when as only text at the beginning of next line?

@crasbe crasbe added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crasbe crasbe crasbe left review comments
@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner
@basilfx basilfx Awaiting requested review from basilfx basilfx is a code owner
@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner
@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner
@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner
@gschorcht gschorcht Awaiting requested review from gschorcht gschorcht is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

AI: Not Used AI was stated to not be used in this PR/Issue Area: BLE Area: Bluetooth Low Energy support Area: boards Area: Board ports Area: examples Area: Example Applications Area: LoRa Area: LoRa radio support Area: network Area: Networking Area: pkg Area: External package ports CI: no fast fail don't abort PR build after first error CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@krzysztof-cabaj @riot-ci @crasbe