FWT-146 Start Drinking On (SDO) company time#112
FWT-146 Start Drinking On (SDO) company time#112DiegoLHendrix wants to merge 41 commits intomainfrom
Conversation
…re/diegolhendrix/sdo-sample
…re/diegolhendrix/sdo-sample
DiegoLHendrix
changed the title
…re/diegolhendrix/sdo-sample
…re/diegolhendrix/sdo-sample
mjh9585
left a comment
mjh9585
left a comment
There was a problem hiding this comment.
Just a few changes, mostly should make a method to register a callback that is used by the sdo.
mjh9585
left a comment
mjh9585
left a comment
There was a problem hiding this comment.
Just a couple of changes. Make sure to clean up leftover code from the unresolved comments.
mjh9585
left a comment
mjh9585
left a comment
There was a problem hiding this comment.
A couple of changes. I noticed a lot of resolved comments that didn't seem to have anything changed for them, did you forget to push something? I marked them as unresolved and left a comment on most of them.
…/RIT-EVT/EVT-core into feature/diegolhendrix/sdo-sample
mjh9585
left a comment
mjh9585
left a comment
There was a problem hiding this comment.
Overall pretty good, just needs a few changes and a little polish. Also you never take advantage of your blocking methods in your sample which could be helpful to see an example for simple use cases.
3 participants
No description provided.