Bob the Building Samples

[ActuallyTaylor]

Created a new Create Sample Builds action that creates an artifact of all samples from EVT-Core. This also includes a fix for cmake.yml that actually builds f446 for all PRs. A fix to IWDG on f446 was needed for this. The definition of IWDG was missing from the f446 definitions in manager.hpp.

The Create Sample Builds action produces debug and release.

All Changes

• Added release.yml GitHub Action that creates debug & release builds of all samples.
• Re-introduced f446 builds to the main PR GitHub Action (cmake.yml).
• Added a missing definition in manager.hpp for IWDG on f446.
• Fixed a comment in IWDGf446.cpp that mentioned F3.

[aclowmclaughlin]

Some minor typo changes.

[aclowmclaughlin]

Approving- btw I don't think there is an issue with setting the permissions to read, I just genuinely didn't know what it did.

[ActuallyTaylor]

Approving- btw I don't think there is an issue with setting the permissions to read, I just genuinely didn't know what it did.

I assumed you had no issue with it! After reviewing it, I just realized there's not really a point since the cmake.yml files uses older ways to update code. So it doesn't make a ton of sense for it. Maybe in a future pr we can update it to use modern action conventions!

[DannyCato]

I'm kind of confused on the need to build samples in release mode. What would that give us as a benefit?

If we are building binaries, wouldn't we rather them be .elfs instead?

Small questions, but overall looks good to me. Just want to make sure before I approve

[ActuallyTaylor]

@DannyCato

I'm kind of confused on the need to build samples in release mode. What would that give us as a benefit?

Building in release mode is not strictly needed for samples. To be honest, its not needed at all. But, the point of this PR was to build a backbone for future GitHub actions on all other repositories to build debug and release builds of targets.

If we are building binaries, wouldn't we rather them be .elfs instead?

.elfs would be useful for our analysis, but we never flash them onto boards. By providing the built .bin files we can flash pieces of a bike by just downloading the last working releases from GitHub. This will make race day flashing a lot easier, and reduce the need for firmware team members to build projects for EEs or Integration when they just need to quickly validate a board.

[DannyCato]

I like those reasons