Debranding #327
Debranding #327
Conversation
|
Hey I went through everything it looks good |
There was a problem hiding this comment.
This information seems like it may be irrelevant to the README file in the root directory. Consider moving the information about the content editor to a .md markdown file in the test_cases directory.
There was a problem hiding this comment.
I will double check, I believe the professor wanted it like this.
senior_projects.db
Outdated
There was a problem hiding this comment.
I would recommend removing this from the pull request, as there are no changes on it.
| }) | ||
| .catch((error) => { | ||
| console.error("Error fetching footer:", error); | ||
| setFooterHtml(""); |
There was a problem hiding this comment.
Instead of completely removing the footer's HTML, maybe we could leave an error message?
There was a problem hiding this comment.
Yes I can look into that! We could discuss this Friday too!
There was a problem hiding this comment.
I appreciate the hardcoded strings and configuration variables being centered in this file! This should be great for maintainability moving forward.
not used/ empty
Changes in this PR
Added 2 editable content areas
loggedOutFooterloggedInFooter(note: the version number is not editable)Header Logo
To change the header logo, add images to:
RIT-SE-Senior-Project/ui/src/AssetsFooter Logo
To change the footer logo, add images to:
RIT-SE-Senior-Project\ui\public\assets