-
Notifications
You must be signed in to change notification settings - Fork 2
Error Logging #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Error Logging #331
Conversation
andymeneely
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you remove the change to package-lock.json
llf5185
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally consider adding .read table_sql/error_log.sql to the file create_all_tables.sql for the sake of testing.
| marginLeft: "10px", | ||
| background: "none", | ||
| border: "none", | ||
| color: "#2185d0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This color gets reused, consider adding it to css/base/variables.css instead of hardcoding it.
| ), | ||
| }, | ||
| { | ||
| menuItem: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The errors tab shouldn't be visible to users without administrative privileges.
| </span> | ||
| )} | ||
| {log.stack_trace && ( | ||
| <button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider importing buttons from semantic so that stylization is consistent with buttons elsewhere in the website.
This PR adds an error logging tab with automatically tracked errors in the backend. This only tracks errors on the backend (i.e. API route failures, database issues, etc.).