Skip to content

Fix for DYNAMIXEL-Y control table error #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonghee-son wants to merge 3 commits into from
Closed

Fix for DYNAMIXEL-Y control table error #145

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
674c5fb
[Fix] Fixed DYNAMIXEL-Y PRESENT_MOTOR_TEMPERATURE ControlTableItem Width
jonghee-son Apr 15, 2025
2ec236b
Revert "[Fix] Fixed DYNAMIXEL-Y PRESENT_MOTOR_TEMPERATURE ControlTabl…
jonghee-son Apr 15, 2025
f6aa9f4
[Fix] Fixed DYNAMIXEL-Y PRESENT_MOTOR_TEMPERATURE ControlTableItem Width
jonghee-son Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/actuator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ const ModelControlTableInfo_t y_control_table[] PROGMEM = {
{ControlTableItem::VELOCITY_TRAJECTORY, 564, 4},
{ControlTableItem::PRESENT_INPUT_VOLTAGE, 568, 2},
{ControlTableItem::PRESENT_TEMPERATURE, 570, 1}, // Present Inverter Temperature
{ControlTableItem::PRESENT_MOTOR_TEMPERATURE, 571, 4},
{ControlTableItem::PRESENT_MOTOR_TEMPERATURE, 571, 1},
Comment on lines 495 to +496
Copy link

@gemini-code-assist gemini-code-assist bot Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The data width for PRESENT_MOTOR_TEMPERATURE is being corrected from 4 to 1. This aligns with the DYNAMIXEL-Y series e-Manual, as linked in the pull request description. Is there any additional validation or testing that can be done to confirm this?

Suggested change
{ControlTableItem::PRESENT_TEMPERATURE, 570, 1}, // Present Inverter Temperature
{ControlTableItem::PRESENT_MOTOR_TEMPERATURE, 571, 4},
{ControlTableItem::PRESENT_MOTOR_TEMPERATURE, 571, 1},
{ControlTableItem::PRESENT_TEMPERATURE, 570, 1}, // Present Inverter Temperature
{ControlTableItem::PRESENT_MOTOR_TEMPERATURE, 571, 1},

#endif
{ControlTableItem::LAST_DUMMY_ITEM, 0, 0}
};
Expand Down