Skip to content

Added ci, lint and bump #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 18, 2025
Merged

Added ci, lint and bump #13

merged 6 commits into from
Feb 18, 2025

Conversation

@yun-goon
Copy link
Member

@yun-goon yun-goon commented Feb 17, 2025 •
edited
Loading

Description

Added ci, lint and bump

@yun-goon
Added ci, lint
c83f82d 
Signed-off-by: Wonho Yun <[email protected]>
@yun-goon yun-goon self-assigned this Feb 17, 2025
@robotpilot robotpilot added the enhancement New feature or request label Feb 17, 2025
robotpilot
robotpilot approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@robotpilot robotpilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yun-goon and others added 2 commits February 17, 2025 17:22
@yun-goon yun-goon changed the title Added ci, lint Added ci, lint and bump Feb 17, 2025
@robotpilot
Copy link
Member

robotpilot commented Feb 17, 2025

@yun-goon Please take a look at the errors below.
https://github.com/ROBOTIS-GIT/dynamixel_hardware_interface/actions/runs/13366031888/job/37324911694#step:6:980

@yun-goon
Modified the header
dabe6c3 
Signed-off-by: Wonho Yun <[email protected]>
@yun-goon
Copy link
Member Author

yun-goon commented Feb 18, 2025

@robotpilot Using Docker to check on Rolling, I found that the files
/opt/ros/rolling/include/realtime_tools/realtime_tools/realtime_publisher.h and
/opt/ros/rolling/include/realtime_tools/realtime_tools/realtime_server_goal_handle.h
were missing.

When checking on Humble, I noticed that these files contained the following directive:

#pragma message( \
  "This header include is deprecated. Please update your code to use 'realtime_server_goal_handle.hpp' header.")  //NOLINT

So, I replaced them with the .hpp versions accordingly.
I also confirmed that OpenManipulator is working correctly.

@robotpilot
Copy link
Member

robotpilot commented Feb 18, 2025

Thanks, @yun-goon :)

@robotpilot robotpilot enabled auto-merge February 18, 2025 01:06
@robotpilot
Copy link
Member

robotpilot commented Feb 18, 2025

@sunghowoo PING

sunghowoo
sunghowoo approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@sunghowoo sunghowoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, LINT and CI has been added to the SDK. Great job!

@robotpilot robotpilot merged commit 9d10eab into main Feb 18, 2025
11 checks passed
@robotpilot robotpilot deleted the feature-humble-lint-ci branch February 18, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robotpilot robotpilot robotpilot approved these changes

@sunghowoo sunghowoo sunghowoo approved these changes

Assignees

@yun-goon yun-goon

Labels

enhancement New feature or request

Projects

Platform
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yun-goon @robotpilot @sunghowoo