Bump 1.4.1

[robotpilot]

No description provided.

[gemini-code-assist]

Hello @robotpilot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request bumps the version of the dynamixel_hardware_interface package to 1.4.1. It includes modifications to the model file, specifically adding new Dynamixel models and updating existing ones. Additionally, the error_timeout_sec parameter in the README has been updated to error_timeout_ms to reflect that the timeout is now in milliseconds.

Highlights

• Version Bump: The package version has been bumped from 1.4.0 to 1.4.1.
• Model File Modification: The dynamixel.model file has been updated to include new Dynamixel models (ph42_020_s300.model and ym080_230_b001.model) and modify existing ones (ym070_210_r099.model and ym080_230_r099.model).
• README Update: The README file has been updated to reflect that the error_timeout parameter is now in milliseconds (error_timeout_ms).

Changelog

Click here to see the changelog

• CHANGELOG.rst
  • Added a changelog entry for version 1.4.1, noting the model file modification.
  • Added Wonho Yun as a contributor.
• README.md
  • Changed error_timeout_sec to error_timeout_ms to indicate milliseconds.
• package.xml
  • Updated the package version to 1.4.1.
• param/dxl_model/dynamixel.model
  • Added ph42_020_s300.model to the list of models.
  • Added ym080_230_b001.model to the list of models.
• param/dxl_model/ph42_020_s300.model
  • Added a new model file for ph42_020_s300 Dynamixel.
• param/dxl_model/xh430_v210.model
  • No functional change, just ensuring newline at end of file.
• param/dxl_model/ym070_210_r099.model
  • Modified value_of_zero_radian_position, value_of_max_radian_position, and value_of_min_radian_position.
• param/dxl_model/ym080_230_b001.model
  • Added a new model file for ym080_230_b001 Dynamixel.
• param/dxl_model/ym080_230_r099.model
  • Modified value_of_zero_radian_position, value_of_max_radian_position, and value_of_min_radian_position.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

A millisecond's brief flight,
Changes timeout, day and night,
Models new appear,
Version's getting clear,
Code evolves with all its might.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request bumps the version to 1.4.1, updates the changelog, modifies the README, and updates/adds dynamixel model files. The changes seem straightforward and necessary for keeping the package up-to-date.

Summary of Findings

• Inconsistent timeout units: The README.md file was updated to reflect that error_timeout_ms is in milliseconds, but the code itself should be checked to ensure that this change is reflected in the actual implementation. It's important to maintain consistency between documentation and code.
• Model file updates: The addition of new model files and modification of existing ones should be verified to ensure that the new models are correctly configured and that the changes to existing models do not introduce any regressions.

Merge Readiness

The pull request seems to be in good shape for merging, but the timeout units and model file updates should be verified before merging. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging. Given the medium severity comment, I recommend that this be addressed before merging.

[gemini-code-assist]

The description was updated to indicate that the timeout is in milliseconds. Ensure that the code implementation actually uses milliseconds and not seconds, to avoid unexpected behavior. If the code uses seconds, the documentation should be reverted or the code should be updated to use milliseconds.