-
Notifications
You must be signed in to change notification settings - Fork 10
Fix deprecated hardware_interface API #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @christophfroehlich, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the on_init
method to use the new hardware_interface::HardwareComponentInterfaceParams
API, addressing the deprecation of using hardware_interface::HardwareInfo
directly. The changes in both the header and source files are appropriate. I have one suggestion to update the documentation to maintain consistency with the API change.
hardware_interface::CallbackReturn on_init( | ||
const hardware_interface::HardwareComponentInterfaceParams & params) override; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the function signature is correctly updated, the corresponding Doxygen comment at line 115 is now out of sync. Please update the @param
tag to reflect the new parameter name and type for better code clarity and maintainability.
For example:
* @param params Parameters for the hardware component interface.
See ros-controls/ros2_control#2323
needed for ros-controls/ros2_control#2589
Please release it to kilted and rolling, thanks :)