Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions turtlebot3_applications/CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
Changelog for package turtlebot3_applications
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1.3.1 (2025-06-20)
------------------
* Fix cmake error in turtlebot3_panorama
* Contributors: Hyungyu Kim

1.3.0 (2025-06-04)
------------------
* Added turtlebot3_yolo_object_detection pkg
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_applications/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>turtlebot3_applications</name>
<version>1.3.0</version>
<version>1.3.1</version>
<description>
ROS packages for the turtlebot3 applications (meta package)
</description>
Expand Down
4 changes: 4 additions & 0 deletions turtlebot3_aruco_tracker/CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
Changelog for package turtlebot3_aruco_tracker
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1.3.1 (2025-06-20)
------------------
* None

1.3.0 (2025-06-04)
------------------
* None
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_aruco_tracker/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>turtlebot3_aruco_tracker</name>
<version>1.3.0</version>
<version>1.3.1</version>
<description>
ArUco Tracker for TurtleBot3 Examples.
</description>
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_aruco_tracker/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

setup(
name=package_name,
version='1.3.0',
version='1.3.1',
packages=find_packages(),
data_files=[
('share/ament_index/resource_index/packages', ['resource/' + package_name]),
Expand Down
4 changes: 4 additions & 0 deletions turtlebot3_automatic_parking/CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
Changelog for package turtlebot3_automatic_parking
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1.3.1 (2025-06-20)
------------------
* None

1.3.0 (2025-06-04)
------------------
* None
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_automatic_parking/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>turtlebot3_automatic_parking</name>
<version>1.3.0</version>
<version>1.3.1</version>
<description>
Package for turtlebot3 automatic_parking. You need a reflective tape and real robots. You can see parking spot using this pacakge on rviz.

Copilot AI Jun 20, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in 'pacakge'; please change it to 'package' to improve the clarity of the package description.

Suggested change
Package for turtlebot3 automatic_parking. You need a reflective tape and real robots. You can see parking spot using this pacakge on rviz.
Package for turtlebot3 automatic_parking. You need a reflective tape and real robots. You can see parking spot using this package on rviz.

Copilot uses AI. Check for mistakes.
</description>
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_automatic_parking/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

setup(
name=package_name,
version='1.3.0',
version='1.3.1',
packages=find_packages(),
data_files=[
('share/ament_index/resource_index/packages', ['resource/' + package_name]),
Expand Down
4 changes: 4 additions & 0 deletions turtlebot3_automatic_parking_vision/CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
Changelog for package turtlebot3_automatic_parking_vision
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1.3.1 (2025-06-20)
------------------
* None

1.3.0 (2025-06-04)
------------------
* None
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_automatic_parking_vision/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>turtlebot3_automatic_parking_vision</name>
<version>1.3.0</version>
<version>1.3.1</version>
<description>
Automatic Parking Vision for TurtleBot3 Examples.
</description>
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_automatic_parking_vision/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

setup(
name=package_name,
version='1.3.0',
version='1.3.1',
packages=find_packages(),
data_files=[
('share/ament_index/resource_index/packages', ['resource/' + package_name]),
Expand Down
4 changes: 4 additions & 0 deletions turtlebot3_follower/CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
Changelog for package turtlebot3_follower
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1.3.1 (2025-06-20)
------------------
* None

1.3.0 (2025-06-04)
------------------
* None
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_follower/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>turtlebot3_follower</name>
<version>1.3.0</version>
<version>1.3.1</version>
<description>
TurtleBot3 Follower Example for ROS2.
</description>
Expand Down
5 changes: 5 additions & 0 deletions turtlebot3_panorama/CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
Changelog for package turtlebot3_panorama
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1.3.1 (2025-06-20)
------------------
* Fix cmake error in turtlebot3_panorama
* Contributors: Hyungyu Kim

1.3.0 (2025-06-04)
------------------
* None
Expand Down
24 changes: 5 additions & 19 deletions turtlebot3_panorama/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,26 +12,12 @@ if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wno-ignored-qualifiers -Wno-reorder -Wall -Wextra)
endif()

if(DEFINED ENV{ROS_DISTRO})
set(ROS_DISTRO $ENV{ROS_DISTRO})
endif()

if(NOT DEFINED ROS_DISTRO OR ROS_DISTRO STREQUAL "")
execute_process(
COMMAND printenv ROS_DISTRO
OUTPUT_VARIABLE ROS_DISTRO
OUTPUT_STRIP_TRAILING_WHITESPACE
)
endif()

if(NOT DEFINED ROS_DISTRO OR ROS_DISTRO STREQUAL "")
message(WARNING "ROS_DISTRO is not defined.")
endif()

if(ROS_DISTRO STREQUAL "humble")
if(EXISTS "/opt/ros/humble")
add_definitions(-DROS2_HUMBLE)
elseif(ROS_DISTRO STREQUAL "jazzy" OR ROS_DISTRO STREQUAL "rolling")
add_definitions(-DROS2_JAZZY_OR_ROLLING)
message("Humble")
else()
add_definitions(-DROS2_LATEST)
message("Latest")
Comment on lines +19 to +20

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Defining ROS2_LATEST for all non-Humble distributions assumes that all subsequent ROS 2 versions will share the same characteristics. Add a comment clarifying this assumption, especially regarding the cv_bridge.hpp include style used by Jazzy/Rolling.

endif()
Comment on lines +15 to 21

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The updated method for ROS distribution detection, while simpler, relies on the existence of /opt/ros/humble. This might not be robust as it assumes a standard ROS installation path. Consider prioritizing ROS_DISTRO and falling back to the EXISTS check for broader compatibility. Could you elaborate on the cmake error this change addresses?


################################################################################
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
#include <image_transport/image_transport.hpp>
#ifdef ROS2_HUMBLE
#include <cv_bridge/cv_bridge.h>
#elif defined(ROS2_JAZZY_OR_ROLLING)
#elif defined(ROS2_LATEST)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider adding a comment to this line to explicitly state the assumption that all non-Humble ROS 2 distributions (covered by ROS2_LATEST) use the <cv_bridge/cv_bridge.hpp> header path.

Suggested change
#elif defined(ROS2_LATEST)
#elif defined(ROS2_LATEST) // Assumes cv_bridge.hpp for all non-Humble ROS 2 distributions

#include <cv_bridge/cv_bridge.hpp>
#endif

Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_panorama/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>turtlebot3_panorama</name>
<version>1.3.0</version>
<version>1.3.1</version>
<description>
Package for turtlebot3 panorama.
</description>
Expand Down
4 changes: 4 additions & 0 deletions turtlebot3_yolo_object_detection/CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
Changelog for package turtlebot3_yolo_object_detection
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1.3.1 (2025-06-20)
------------------
* None

1.3.0 (2025-06-04)
------------------
* Added turtlebot3_yolo_object_detection pkg
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_yolo_object_detection/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>turtlebot3_yolo_object_detection</name>
<version>1.3.0</version>
<version>1.3.1</version>
<description>
YOLO-based object detection for TurtleBot3
</description>
Expand Down
2 changes: 1 addition & 1 deletion turtlebot3_yolo_object_detection/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

setup(
name=package_name,
version='1.3.0',
version='1.3.1',
packages=find_packages(),
data_files=[
('share/ament_index/resource_index/packages', ['resource/' + package_name]),
Expand Down