-
Notifications
You must be signed in to change notification settings - Fork 523
Fix buildfarm error in rolling #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Hyungyu Kim <[email protected]>
Signed-off-by: Hyungyu Kim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes buildfarm errors in the Rolling branch by applying the C-header deprecation changes from PR #720, updating header includes and bumping package versions.
- Bump package versions from 2.3.5 to 2.3.7 in all affected packages
- Replace
.htf2/LinearMath headers with.hppin simulation and fake‐node code - Add
2.3.7entries to each package’s CHANGELOG
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| turtlebot3_simulations/package.xml | Updated version to 2.3.7 |
| turtlebot3_simulations/CHANGELOG.rst | Added 2.3.7 changelog entry |
| turtlebot3_gazebo/package.xml | Updated version to 2.3.7 |
| turtlebot3_gazebo/include/turtlebot3_gazebo/turtlebot3_drive.hpp | Switched tf2 includes to .hpp |
| turtlebot3_gazebo/CHANGELOG.rst | Added 2.3.7 changelog entry |
| turtlebot3_fake_node/package.xml | Updated version to 2.3.7 |
| turtlebot3_fake_node/include/turtlebot3_fake_node/turtlebot3_fake_node.hpp | Switched tf2 include to .hpp |
| turtlebot3_fake_node/CHANGELOG.rst | Added 2.3.7 changelog entry |
Comments suppressed due to low confidence (1)
turtlebot3_fake_node/CHANGELOG.rst:2
- The CHANGELOG header references
turtlebot3_fakebut the package folder isturtlebot3_fake_node. Please update it to match the actual package name.
Changelog for package turtlebot3_fake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @GyuH13, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a buildfarm error in the Rolling distribution by updating tf2/LinearMath header includes from their deprecated .h extensions to the new .hpp extensions. This ensures compatibility with recent modifications in the geometry2 repository, preventing build failures and maintaining the integrity of the TurtleBot3 simulation packages.
Highlights
- Header Updates: Updated
tf2/LinearMathheader includes from their deprecated.hextensions to the new.hppextensions inturtlebot3_fake_nodeandturtlebot3_gazebopackages. This change aligns with recent deprecations in thegeometry2repository. - Versioning: Incremented the package versions for
turtlebot3_fake_node,turtlebot3_gazebo, andturtlebot3_simulationsto2.3.7to reflect these changes. - Documentation: Added corresponding changelog entries for the header file updates in
turtlebot3_fake_node,turtlebot3_gazebo, andturtlebot3_simulations.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several turtlebot3 packages to fix a build error in the ROS 2 Rolling distribution. The fix involves replacing deprecated C-style .h headers from tf2/LinearMath with their modern C++ .hpp equivalents. The package versions and changelogs are also updated to reflect these changes. The modifications are correct and effectively address the described build issue. My review includes one suggestion to improve the clarity of a changelog entry for a metapackage.
Signed-off-by: Hyungyu Kim <[email protected]>
robotpilot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In the Rolling version, the changes from Deprecate C Headers (#720) have been applied.