Skip to content

Conversation

@GyuH13
Copy link
Member

@GyuH13 GyuH13 commented Jun 27, 2025

In the Rolling version, the changes from Deprecate C Headers (#720) have been applied.

GyuH13 added 2 commits June 27, 2025 14:07
Signed-off-by: Hyungyu Kim <[email protected]>
Copilot AI review requested due to automatic review settings June 27, 2025 05:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes buildfarm errors in the Rolling branch by applying the C-header deprecation changes from PR #720, updating header includes and bumping package versions.

  • Bump package versions from 2.3.5 to 2.3.7 in all affected packages
  • Replace .h tf2/LinearMath headers with .hpp in simulation and fake‐node code
  • Add 2.3.7 entries to each package’s CHANGELOG

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
turtlebot3_simulations/package.xml Updated version to 2.3.7
turtlebot3_simulations/CHANGELOG.rst Added 2.3.7 changelog entry
turtlebot3_gazebo/package.xml Updated version to 2.3.7
turtlebot3_gazebo/include/turtlebot3_gazebo/turtlebot3_drive.hpp Switched tf2 includes to .hpp
turtlebot3_gazebo/CHANGELOG.rst Added 2.3.7 changelog entry
turtlebot3_fake_node/package.xml Updated version to 2.3.7
turtlebot3_fake_node/include/turtlebot3_fake_node/turtlebot3_fake_node.hpp Switched tf2 include to .hpp
turtlebot3_fake_node/CHANGELOG.rst Added 2.3.7 changelog entry
Comments suppressed due to low confidence (1)

turtlebot3_fake_node/CHANGELOG.rst:2

  • The CHANGELOG header references turtlebot3_fake but the package folder is turtlebot3_fake_node. Please update it to match the actual package name.
Changelog for package turtlebot3_fake

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @GyuH13, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a buildfarm error in the Rolling distribution by updating tf2/LinearMath header includes from their deprecated .h extensions to the new .hpp extensions. This ensures compatibility with recent modifications in the geometry2 repository, preventing build failures and maintaining the integrity of the TurtleBot3 simulation packages.

Highlights

  • Header Updates: Updated tf2/LinearMath header includes from their deprecated .h extensions to the new .hpp extensions in turtlebot3_fake_node and turtlebot3_gazebo packages. This change aligns with recent deprecations in the geometry2 repository.
  • Versioning: Incremented the package versions for turtlebot3_fake_node, turtlebot3_gazebo, and turtlebot3_simulations to 2.3.7 to reflect these changes.
  • Documentation: Added corresponding changelog entries for the header file updates in turtlebot3_fake_node, turtlebot3_gazebo, and turtlebot3_simulations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several turtlebot3 packages to fix a build error in the ROS 2 Rolling distribution. The fix involves replacing deprecated C-style .h headers from tf2/LinearMath with their modern C++ .hpp equivalents. The package versions and changelogs are also updated to reflect these changes. The modifications are correct and effectively address the described build issue. My review includes one suggestion to improve the clarity of a changelog entry for a metapackage.

Signed-off-by: Hyungyu Kim <[email protected]>
@GyuH13 GyuH13 requested a review from robotpilot June 27, 2025 05:32
Copy link
Member

@robotpilot robotpilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robotpilot robotpilot enabled auto-merge June 27, 2025 08:34
@robotpilot robotpilot disabled auto-merge June 27, 2025 08:35
@robotpilot robotpilot added the bug Something isn't working label Jun 27, 2025
@robotpilot robotpilot merged commit 9be186f into main Jun 27, 2025
10 checks passed
@robotpilot robotpilot deleted the feature-rolling-buildfarm-error branch June 27, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants