rocr/aie: Handle non-HSA_STATUS_SUCCESS during VisitRegion

[ypapadop-amd]

This PR address a bug that hides the result of a visit during AieAgent::VisitRegion.

[atgutier]

Good catch. One minor nit: I know I was using status, but I noticed that err seems to be common elsewhere. Can you rename the status var to err here? Thanks!

[ypapadop-amd]

Good catch. One minor nit: I know I was using status, but I noticed that err seems to be common elsewhere. Can you rename the status var to err here? Thanks!

You mean stat? I don't see err in AieAgent; I picked it up from

ROCR-Runtime/runtime/hsa-runtime/core/runtime/amd_gpu_agent.cpp

Line 723 in 26f001d

hsa_status_t status = call(region_handle, data);

[atgutier]

Good catch. One minor nit: I know I was using status, but I noticed that err seems to be common elsewhere. Can you rename the status var to err here? Thanks!

You mean stat? I don't see err in AieAgent; I picked it up from

ROCR-Runtime/runtime/hsa-runtime/core/runtime/amd_gpu_agent.cpp

Line 723 in 26f001d

hsa_status_t status = call(region_handle, data);

No, I just mean generally throughout the runtime they use err for hsa_status_t codes.

[ypapadop-amd]

Good catch. One minor nit: I know I was using status, but I noticed that err seems to be common elsewhere. Can you rename the status var to err here? Thanks!

You mean stat? I don't see err in AieAgent; I picked it up from

ROCR-Runtime/runtime/hsa-runtime/core/runtime/amd_gpu_agent.cpp

Line 723 in 26f001d

hsa_status_t status = call(region_handle, data);

No, I just mean generally throughout the runtime they use err for hsa_status_t codes.

OK. Just this instance or do you mean the whole file? BTW, it can also be HSA_STATUS_INFO_BREAK, which is not error, just an early exit (i.e., you found what you were looking for and you don't want the visitor to continue).

[atgutier]

Good catch. One minor nit: I know I was using status, but I noticed that err seems to be common elsewhere. Can you rename the status var to err here? Thanks!

You mean stat? I don't see err in AieAgent; I picked it up from

ROCR-Runtime/runtime/hsa-runtime/core/runtime/amd_gpu_agent.cpp

Line 723 in 26f001d

hsa_status_t status = call(region_handle, data);

No, I just mean generally throughout the runtime they use err for hsa_status_t codes.

OK. Just this instance or do you mean the whole file? BTW, it can also be HSA_STATUS_INFO_BREAK, which is not error, just an early exit (i.e., you found what you were looking for and you don't want the visitor to continue).

Up to you if you want to change the whole file. Would probably be for the best as I prefer we remain consistent with existing style when possible.

[atgutier]

LGTM, thanks!

[ypapadop-amd]

@dayatsin-amd any comments?

[dayatsin-amd]

LGTM. Thank you

[ammallya]

!verify

[ypapadop-amd]

I think that this can be closed now.