Skip to content

Commit 6ae5971

Browse files
ScottToddjharryma
ScottTodd
authored and
jharryma
committed
[torch] Enable stable torch 2.9 builds on Windows and update docs (#1809)
## Motivation Fixes #1677, filling in the latest support matrix for supported PyTorch versions for our nightly release builds. I also took the opportunity to clarify and refresh the documentation. ## Technical Details For now this uses `release/2.9_rocm7.9`. Depends on ROCm/pytorch#2712 to use `release/2.9`. ## Test Plan Trigger test release builds using https://github.com/ROCm/TheRock/actions/workflows/release_windows_pytorch_wheels.yml - [ ] Test `release/2.9` once that PR is merged - [x] Test `release/2.9_rocm7.9`: https://github.com/ROCm/TheRock/actions/runs/18598633844 ## Test Results Test release builds completed and sanity checks passed.
1 parent 1273b50 commit 6ae5971

File tree

3 files changed

+35
-32
lines changed

3 files changed

+35
-32
lines changed

‎.github/workflows/release_portable_linux_pytorch_wheels.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,6 @@ jobs:
8787
include:
8888
- pytorch_version: release/2.7
8989
pytorch_patchset: rocm_2.7
90-
# - pytorch_version: release/2.8
91-
# pytorch_patchset: rocm_2.8
9290
- pytorch_version: release/2.9
9391
pytorch_patchset: rocm_2.9
9492
- pytorch_version: nightly

‎.github/workflows/release_windows_pytorch_wheels.yml‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,13 +83,12 @@ jobs:
8383
fail-fast: false
8484
matrix:
8585
python_version: ["3.11", "3.12", "3.13"]
86-
# TODO(#1677): Get 2.9 build working and enable it
87-
# pytorch_version: ["release/2.9", "nightly"]
88-
pytorch_version: ["nightly"]
86+
# TODO(#1677): use release/2.9 (common branch) instead of release/2.9_rocm7.9
87+
# once https://github.com/ROCm/pytorch/pull/2712 cherry-picks are merged
88+
pytorch_version: ["release/2.9_rocm7.9", "nightly"]
8989
include:
90-
# TODO(#1677): Get 2.9 builds working and enable them
91-
# - pytorch_version: release/2.9
92-
# pytorch_patchset: rocm_2.9
90+
- pytorch_version: release/2.9_rocm7.9
91+
pytorch_patchset: rocm_2.9
9392
- pytorch_version: nightly
9493
pytorch_patchset: nightly
9594

‎external-builds/pytorch/README.md‎

Lines changed: 30 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -28,41 +28,47 @@ This incorporates advice from:
2828

2929
### Project and feature support status
3030

31-
<!-- TODO: Add when aotriton was enabled on Windows (2.10) -->
32-
33-
| Project / feature | Linux support | Windows support |
34-
| ------------------------------ | ----------------------------------------------------------------------------------------------------------------------------- | --------------- |
35-
| torch | ✅ Supported | ✅ Supported |
36-
| torchaudio | ✅ Supported | ✅ Supported |
37-
| torchvision | ✅ Supported | ✅ Supported |
38-
| Flash attention via [ao]triton | ✅ Supported for torch < 2.10<br>❌ Disabled for torch ≥ 2.10 (see [Issue#1408](https://github.com/ROCm/TheRock/issues/1408)) | ✅ Supported |
31+
| Project / feature | Linux support | Windows support |
32+
| ------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------- |
33+
| torch | ✅ Supported | ✅ Supported |
34+
| torchaudio | ✅ Supported | ✅ Supported |
35+
| torchvision | ✅ Supported | ✅ Supported |
36+
| Flash attention via [ao]triton | ✅ Supported for torch 2.7<br>❌ Not yet supported for newer versions (see [Issue#1408](https://github.com/ROCm/TheRock/issues/1408)) | ✅ Supported since torch 2.9 |
3937

4038
### Supported PyTorch versions
4139

42-
We support building ROCm source and nightly releases together with several
43-
different PyTorch versions. The intent is to support the latest upstream PyTorch
44-
code (i.e. `main` or `nightly`) as well as recently published release branches
45-
which users depend on. Developers can also build variations of these versions to
46-
suite their own requirements.
40+
We support building various PyTorch versions compatible with the latest ROCm
41+
sources and release packages.
42+
43+
Support for the latest upstream PyTorch code (i.e. `main` or `nightly`) uses the
44+
upstream projects directly, while extended support for older releases is maintained
45+
via backported release branches in https://github.com/ROCm/pytorch. Developers can
46+
also build variations of these versions to suite their own requirements.
47+
48+
> [!NOTE]
49+
> We build "nightly" versions with alpha suffixes. Once
50+
> PyTorch promotes a new release version, we switch from the upstream branches
51+
> to the backported release branches in https://github.com/ROCm/pytorch without
52+
> such version suffixes (e.g. `2.7.0a0`-> `2.7.1`).
53+
>
54+
> Historical builds are archived at https://rocm.nightlies.amd.com according to
55+
> some retention policy.
4756
4857
Each PyTorch version uses a combination of:
4958

5059
- Git repository URLs for each project
5160
- Git "repo hashtags" (branch names, tag names, or commit refs) for each project
5261
- Optional patches to be applied on top of a git checkout
5362

54-
See the following table for how each version is supported. Previously supported
55-
versions are no longer being built but may have existing wheels in the
56-
[nightly build repo](https://rocm.nightlies.amd.com/v2/).
57-
58-
<!-- TODO: update this support table once we publish 2.9 stable for Linux and Windows -->
63+
See the following table for how each version is supported:
5964

60-
| PyTorch version | Linux | Windows |
61-
| -------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
62-
| nightly (2.10 alpha) | ✅ Using upstream pytorch<br><ul><li>[pytorch/pytorch `nightly` branch](https://github.com/pytorch/pytorch/tree/nightly)<ul><li>[ROCm/triton](https://github.com/ROCm/triton) - [`ci_commit_pins/triton.txt`](https://github.com/pytorch/pytorch/blob/nightly/.ci/docker/ci_commit_pins/triton.txt)</li></ul></li><li>[pytorch/audio `nightly` branch](https://github.com/pytorch/audio/tree/nightly)</li><li>[pytorch/vision `nightly` branch](https://github.com/pytorch/vision/tree/nightly)</li></ul> | ✅ Using upstream pytorch<br><ul><li>[pytorch/pytorch `nightly` branch](https://github.com/pytorch/pytorch/tree/nightly)</li><li>[pytorch/audio `nightly` branch](https://github.com/pytorch/audio/tree/nightly)</li><li>[pytorch/vision `nightly` branch](https://github.com/pytorch/vision/tree/nightly)</li></ul> |
63-
| 2.9 alpha | Previously supported | Previously supported |
64-
| 2.8 | Unsupported | Unsupported |
65-
| 2.7 | ✅ Using downstream ROCm/pytorch fork<br><ul><li>[ROCm/pytorch `release/2.7` branch](https://github.com/ROCm/pytorch/tree/release/2.7)<ul><li>[ROCm/triton](https://github.com/ROCm/triton) - [`ci_commit_pins/triton.txt`](https://github.com/ROCm/pytorch/blob/release/2.7/.ci/docker/ci_commit_pins/triton.txt)</li></ul></li><li>[pytorch/audio](https://github/com/pytorch/audio) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.7/related_commits)</li><li>[pytorch/vision](https://github/com/pytorch/vision) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.7/related_commits)</li></ul> | Unsupported |
65+
| PyTorch version | Linux | Windows |
66+
| --------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
67+
| 2.10 alpha | ✅ Using upstream pytorch<br><ul><li>[pytorch/pytorch `nightly` branch](https://github.com/pytorch/pytorch/tree/nightly)<ul><li>[ROCm/triton](https://github.com/ROCm/triton) - [`ci_commit_pins/triton.txt`](https://github.com/pytorch/pytorch/blob/nightly/.ci/docker/ci_commit_pins/triton.txt)</li></ul></li><li>[pytorch/audio `nightly` branch](https://github.com/pytorch/audio/tree/nightly)</li><li>[pytorch/vision `nightly` branch](https://github.com/pytorch/vision/tree/nightly)</li></ul> | ✅ Using upstream pytorch<br><ul><li>[pytorch/pytorch `nightly` branch](https://github.com/pytorch/pytorch/tree/nightly)</li><li>[pytorch/audio `nightly` branch](https://github.com/pytorch/audio/tree/nightly)</li><li>[pytorch/vision `nightly` branch](https://github.com/pytorch/vision/tree/nightly)</li></ul> |
68+
| 2.9 | ✅ Using downstream ROCm/pytorch fork<br><ul><li>[ROCm/pytorch `release/2.9` branch](https://github.com/ROCm/pytorch/tree/release/2.9)<ul><li>[ROCm/triton](https://github.com/ROCm/triton) - [`ci_commit_pins/triton.txt`](https://github.com/ROCm/pytorch/blob/release/2.9/.ci/docker/ci_commit_pins/triton.txt)</li></ul></li><li>[pytorch/audio](https://github/com/pytorch/audio) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.9/related_commits)</li><li>[pytorch/vision](https://github/com/pytorch/vision) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.9/related_commits)</li></ul> | ✅ Using downstream ROCm/pytorch fork<br><ul><li>[ROCm/pytorch `release/2.9_rocm7.9` branch](https://github.com/ROCm/pytorch/tree/release/2.9_rocm7.9)</li><li>[pytorch/audio](https://github/com/pytorch/audio) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.9_rocm7.9/related_commits)</li><li>[pytorch/vision](https://github/com/pytorch/vision) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.9_rocm7.9/related_commits)</li></ul> |
69+
| 2.9 alpha | Previously built | Previously built |
70+
| 2.8 | Unsupported | Unsupported |
71+
| 2.7 | ✅ Using downstream ROCm/pytorch fork<br><ul><li>[ROCm/pytorch `release/2.7` branch](https://github.com/ROCm/pytorch/tree/release/2.7)<ul><li>[ROCm/triton](https://github.com/ROCm/triton) - [`ci_commit_pins/triton.txt`](https://github.com/ROCm/pytorch/blob/release/2.7/.ci/docker/ci_commit_pins/triton.txt)</li></ul></li><li>[pytorch/audio](https://github/com/pytorch/audio) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.7/related_commits)</li><li>[pytorch/vision](https://github/com/pytorch/vision) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.7/related_commits)</li></ul> | Unsupported |
6672

6773
See also:
6874

0 commit comments

Comments
 (0)