Skip to content

gfx1152/gfx1153: enable rocWMMA build#2650

Merged
mgehre-amd merged 1 commit intomainfrom
user/mgehre-amd/gfx115X_rocWMMA
Jan 27, 2026
Merged

gfx1152/gfx1153: enable rocWMMA build#2650
mgehre-amd merged 1 commit intomainfrom
user/mgehre-amd/gfx115X_rocWMMA

Conversation

@mgehre-amd
Copy link
Contributor

@mgehre-amd mgehre-amd commented Dec 19, 2025

Support for gfx1152/gfx1153 in rocWMMA was merged in ROCm/rocm-libraries#2850
and that PR was included in the last rocm-libaries bump.
I have seen the test pass locally.

Note that runners and testing is currently disabled for gfx1153, but hopefully will come back soon (#2682)

@mgehre-amd mgehre-amd mentioned this pull request Dec 19, 2025
72 tasks
@mgehre-amd mgehre-amd mentioned this pull request Jan 5, 2026
1 task
@mgehre-amd mgehre-amd force-pushed the user/mgehre-amd/gfx115X_rocWMMA branch from e43128f to 12cdbd5 Compare January 7, 2026 12:38
@mgehre-amd mgehre-amd marked this pull request as ready for review January 7, 2026 12:38
@mgehre-amd mgehre-amd changed the title gfx1152/gfx1153: enable rocWMMA gfx1152/gfx1153: enable rocWMMA build Jan 7, 2026
@mgehre-amd mgehre-amd requested a review from bsyrowik January 7, 2026 12:40
@bsyrowik
Copy link
Contributor

bsyrowik commented Jan 7, 2026

Are the GitHub runners now available for gfx1152/3?

@mgehre-amd
Copy link
Contributor Author

Are the GitHub runners now available for gfx1152/3?

The runners themselves are online, but testing on 1152/1153 got disabled after observing hangs on the runners (see #2682). I'm working with DevOps to investigate the hangs and re-enable test runs.

@marbre
Copy link
Member

marbre commented Jan 13, 2026

We had an issue with a history rewrite which confused the GH UI and the commits it is showing on your PR. Please make sure to update your branch e.g. in the GH UI via

image

Afterwards you need update your local branch via git pull.

Alternative git rebase solution

Alternatively you can manually update your branch locally by following the below instructions:

git checkout <yourbranch>
git fetch origin main
git rebase origin/main
git push --force-with-lease origin <yourbranch>

@amd-shiraz amd-shiraz requested review from amd-shiraz and removed request for a team January 13, 2026 22:57
Copy link
Contributor

@amd-shiraz amd-shiraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgehre-amd please rebase with main, resolve conflicts and i can review the changes post that. thanks!

Support for gfx1152/gfx1153 in rocWMMA was merged ROCm/rocm-libraries#2850
and that PR was included in the last rocm-libaries bump.
@mgehre-amd mgehre-amd force-pushed the user/mgehre-amd/gfx115X_rocWMMA branch from 12cdbd5 to 239a250 Compare January 15, 2026 10:36
@mgehre-amd mgehre-amd requested a review from amd-shiraz January 15, 2026 10:36
Copy link
Contributor

@amd-shiraz amd-shiraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some things to consider before merging:

  1. rocWMMA actually is supporting gfx1152/gfx1153 end-to-end ?
  2. double check if TheRock gfx1152/gfx1153 + rocWMMA is enabled in CI ?

I would get a pass for this PR from @geomin12 and @jayhawk-commits as well for more historical context.

@bsyrowik
Copy link
Contributor

  1. rocWMMA actually is supporting gfx1152/gfx1153 end-to-end ?

Can you please help me understand what you are asking here? The rocWMMA library supports these devices as much as it supports any other device; rocWMMA will invoke WMMA compiler built-ins for both gfx1152 and 1153. Is that what you are asking?

@mgehre-amd mgehre-amd merged commit 922df19 into main Jan 27, 2026
45 checks passed
@mgehre-amd mgehre-amd deleted the user/mgehre-amd/gfx115X_rocWMMA branch January 27, 2026 16:30
@github-project-automation github-project-automation bot moved this from TODO to Done in TheRock Triage Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants