[rocprofiler-systems] Add third-party dependencies #2657

jbonnell-amd · 2025-12-19T19:58:12Z

Motivation

This change will enable the use of third-party builds from TheRock for the dyninst and other dependenices that rocprofiler-systems uses. Previously, rocprofiler-systems was downloading and building these as part of its CMake build process.

If desired, I can split this PR up into smaller chunks based on the third-party dependency that is being added/modified. However, all of these are required to get rocprofiler-systems building in the new way, so it may lead to additional small PRs to get it all merged together in the end and enable the new build method.

Technical Details

Added tbb third-party dependency
- [Feature]: Add TBB third-party dependency #1902
- Using latest release v2022.3.0
- Needed for dyninst
Added binutils third-party dependency
- [Feature]: Add LIBIBERTY third-party dependency #1903
- Using version binutils-2.45
- Needed for libiberty packages that are required by dyninst
Added dyninst third-party dependency
- [Feature]: Add DYNINST third-party dependency #1905
- Using latest release v13.0.0
- Required for rocprofiler-systems
Modified boost third-party dependency
- Added additional packages chrono, date_time, thread, timer which are needed as a dependency for dyninst
Modified elfutils third-party dependency
- Added -fPIC option to CFLAGS and CPPFLAGS to enable PIC (position-independent code) which is required for rocprofiler-systems
Updated root level CMakeLists.txt to include THEROCK_BUNDLED_BINUTILS option
Updated profiler CMakeLists.txt to remove DROCPROFSYS_BUILD_* CMake arguments, add the new third-party dependencies instead

Test Plan

rocprofiler-systems is able to be built properly with this change, both locally and in pipeline.

Test Result

rocprofiler-systems is able to build successfully without having to download and build its dependencies from source in its build process.

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

…ndency

…ers/dgaliffi/rocprof-sys-merged

jbonnell-amd · 2025-12-29T21:49:08Z

math-libs/CMakeLists.txt

      rocm-cmake
      rocPRIM
      therock-googletest
+      therock-tbb


For some reason, rocthrust configure kept failing due to this error:

Project contains find_package(TBB) for a package available in the super-project but not declared: Add a BUILD_DEPS or RUNTIME_DEPS appropriately

Not sure where this is coming from but added this for now as a workaround. Would appreciate some insight on what the root cause of this might be

I am pretty sure that thrust must have an optional dependency on TBB and is probing for it. TheRock doesn't let that happen (for this reason). You can add TBB to thrust to unblock BUILD_DEPS to unblock this PR but we should really have an explicit flag to enable/disable the TBB dep there vs having implicit behavior like this.

i dread TBB more than Boost 🗡️

@jbonnell-amd can you file an issue and link it here?

third-party/dyninst/CMakeLists.txt

third-party/sysdeps/linux/binutils/CMakeLists.txt

third-party/tbb/CMakeLists.txt

third-party/dyninst/CMakeLists.txt

third-party/sysdeps/linux/binutils/CMakeLists.txt

third-party/tbb/CMakeLists.txt

Co-authored-by: Marius Brehler <[email protected]>

geomin12

lgtm but I will let Laura or someone more familiar with build to review this

ScottTodd · 2026-01-06T20:09:12Z

third-party/boost/CMakeLists.txt

-    "-DTHEROCK_BOOST_LIBRARIES=atomic,filesystem,multi_index,system"
+    "-DTHEROCK_BOOST_LIBRARIES=atomic,chrono,date_time,filesystem,multi_index,system,thread,timer"


Added dyninst third-party dependency

[Feature]: Add DYNINST third-party dependency #1905

Using latest release v13.0.0

Required for rocprofiler-systems

Modified boost third-party dependency

Added additional packages chrono, date_time, thread, timer which are needed as a dependency for dyninst

We really shouldn't be expanding our dependency on boost, especially not for relatively simple utilities like these. This is especially problematic if the dependency is indirect, as that could make migrating away more difficult.

Should we consider these "grandfathered in" and allow them to be added here, or draw a line and reject them? Either way, the boost dependency must be removed eventually - is the rocprofiler-systems team prioritizing that?

cc @powderluv @stellaraccident

I wish we weren't. But we need to get the whole gang in place before giving any of them a haircut.

ScottTodd · 2026-01-06T20:14:58Z

third-party/sysdeps/linux/binutils/CMakeLists.txt

+  COMMAND
+    make -j 1 V=1


Would this build step benefit from higher parallelism? Logs at https://therock-ci-artifacts.s3.amazonaws.com/20722897507-linux/logs/gfx94X-dcgpu/therock-binutils_build.log suggest this may be taking 5 minutes? Can we try with multithreading?

See how other dependencies use a PAR_JOBS variable:

TheRock/third-party/sysdeps/common/libbacktrace/CMakeLists.txt

Lines 68 to 69 in e07d037

include(ProcessorCount)

ProcessorCount(PAR_JOBS)

TheRock/third-party/sysdeps/common/libbacktrace/CMakeLists.txt

Lines 84 to 85 in e07d037

COMMAND

make -j "${PAR_JOBS}" V=1

Sure, I've updated the make command to use the $PAR_JOBS var instead of just using 1. Thanks!

third-party/CMakeLists.txt

stellaraccident · 2026-01-07T01:34:25Z

BUILD_TOPOLOGY.toml

 feature_group = "MEDIA"
 disable_platforms = ["windows"]

+[artifacts.dyninst]


Please set this up as an optional sysdep in the same way as artifacts.sysdeps-amd-mesa.

It is actually a requirement this is set up this way to comply with LGPL licensing (ensures dynamic linkage). And we enforce this for sysdeps (only).

stellaraccident · 2026-01-07T01:36:04Z

math-libs/CMakeLists.txt

      rocm-cmake
      rocPRIM
      therock-googletest
+      therock-tbb


I am pretty sure that thrust must have an optional dependency on TBB and is probing for it. TheRock doesn't let that happen (for this reason). You can add TBB to thrust to unblock BUILD_DEPS to unblock this PR but we should really have an explicit flag to enable/disable the TBB dep there vs having implicit behavior like this.

stellaraccident · 2026-01-07T01:37:14Z

third-party/CMakeLists.txt

 add_subdirectory(grpc)
+
+# dyninst depends on elfutils, boost, tbb
+add_subdirectory(dyninst)


This needs to go into sysdeps/linux as an optional sysdep. Follow the same pattern as was done for amdmesa.

I'm working on moving dyninst into sysdeps/linux on a side branch, I'll merge the changes back over here once it's all done and confirmed working. Thanks for the feedback!

stellaraccident · 2026-01-07T01:37:53Z

third-party/boost/CMakeLists.txt

-    "-DTHEROCK_BOOST_LIBRARIES=atomic,filesystem,multi_index,system"
+    "-DTHEROCK_BOOST_LIBRARIES=atomic,chrono,date_time,filesystem,multi_index,system,thread,timer"


I wish we weren't. But we need to get the whole gang in place before giving any of them a haircut.

stellaraccident · 2026-01-07T01:39:53Z

third-party/sysdeps/linux/artifact.toml

 ]

+# binutils
+[components.dev."third-party/sysdeps/linux/binutils/build/stage"]


Make this an optional sysdep in the same pattern as amdmesa, with its own artifact.

stellaraccident · 2026-01-07T01:41:41Z

third-party/sysdeps/linux/binutils/CMakeLists.txt

+    "${CMAKE_CURRENT_BINARY_DIR}/s/configure"
+      --prefix "${CMAKE_INSTALL_PREFIX}"
+      --enable-install-libiberty
+      --disable-shared


Add a comment that this is only providing binaries, and even if GPL conditions are satisfied since nothing links to these.

stellaraccident · 2026-01-07T01:42:30Z

third-party/sysdeps/linux/binutils/libiberty-config.cmake.in

+endif()
+
+if(NOT TARGET LibIberty::LibIberty)
+  add_library(LibIberty::LibIberty STATIC IMPORTED)


libiberty is LGPL licensed. We have to use it as a shared library or not at all.

@jbonnell-amd please ping once these comments are resolved and you want another review.

marbre · 2026-01-13T18:04:47Z

We had an issue with a history rewrite which confused the GH UI and the commits it is showing on your PR. Please make sure to update your branch e.g. in the GH UI via

Afterwards you need update your local branch via git pull.

Alternative git rebase solution

Alternatively you can manually update your branch locally by following the below instructions:

git checkout <yourbranch>
git fetch origin main
git rebase origin/main
git push --force-with-lease origin <yourbranch>

jbonnell-amd and others added 19 commits December 11, 2025 17:38

Update rocprofiler-systems subproject, add dependency to Dockerfile

86a0f97

Backup - trying to get TheRock to build Dyninst as a third-party depe…

3b8dc6c

…ndency

Forward COMPONENTS property from "find_package". Used by Boost.

64f0e39

Move deps to "runtime_deps" add "install_rpath_dirs"

486b287

Fix TBB project name in therock_cmake_subproject_provide_package

7812629

Clean up dyninst dependencies

45f97c1

Importing changes from the rocprof-sys branch

5bcf1e7

Use upper case naming for Dyninst in provide package call

debd6b1

Add sysdep binutils

40b7917

Merge branch 'main' into users/dgaliffi/rocprof-sys-merged

3ec47be

Merge remote-tracking branch 'origin/users/dgaliffi/binutils' into us…

b0dbe9c

…ers/dgaliffi/rocprof-sys-merged

Update oneTBB version from 2022.2.0 to 2022.3.0

3ab6c13

Add binutils to runtime_deps for dyninst

8938a45

Update patch_install.sh to move header file locations

4b62b8f

Update comment on binutils section of artifact.toml

b503e48

Add comment for adding S3 bucket URL for binutils

31d69ec

Add fPIC flag in elfutils CMakeLists.txt file

2615916

Update INTERFACE_INCLUDE_DIRECTORIES instead of copying files

8af3121

Merge branch 'main' into users/dgaliffi/rocprof-sys-merged

14fea42

github-project-automation bot added this to TheRock Triage Dec 19, 2025

github-project-automation bot moved this to TODO in TheRock Triage Dec 19, 2025

jbonnell-amd added 7 commits December 19, 2025 15:01

Remove extra line from third-party/CMakeLists.txt

b2e2e88

Merge branch 'main' into users/dgaliffi/rocprof-sys-merged

0c4fb03

Revert therock_subproject_dep_provider.cmake changes for debugging

06a5076

Bring back dep_provider changes

cbfe12e

Add therock-tbb to rocthrust for testing

9b23273

Add therock-tbb runtime_dep to rocprofiler-systems

f6af7f7

Add therock-tbb build_dep to rocthrust to get build passing

5667522

jbonnell-amd commented Dec 29, 2025

View reviewed changes

jbonnell-amd commented Dec 30, 2025

View reviewed changes

third-party/dyninst/CMakeLists.txt Outdated Show resolved Hide resolved

third-party/sysdeps/linux/binutils/CMakeLists.txt Outdated Show resolved Hide resolved

third-party/tbb/CMakeLists.txt Outdated Show resolved Hide resolved

Merge branch 'main' into users/dgaliffi/rocprof-sys-merged

83e22de

jbonnell-amd marked this pull request as ready for review December 30, 2025 21:50

Merge branch 'main' into users/dgaliffi/rocprof-sys-merged

0cadd89

jbonnell-amd requested review from ScottTodd and geomin12 January 2, 2026 20:23

marbre reviewed Jan 5, 2026

View reviewed changes

third-party/dyninst/CMakeLists.txt Outdated Show resolved Hide resolved

third-party/sysdeps/linux/binutils/CMakeLists.txt Outdated Show resolved Hide resolved

third-party/tbb/CMakeLists.txt Outdated Show resolved Hide resolved

marbre self-requested a review January 5, 2026 09:08

jbonnell-amd and others added 4 commits January 5, 2026 11:26

Update third-party/dyninst/CMakeLists.txt

dd558c2

Co-authored-by: Marius Brehler <[email protected]>

Update third-party/sysdeps/linux/binutils/CMakeLists.txt

a1e608b

Co-authored-by: Marius Brehler <[email protected]>

Update third-party/tbb/CMakeLists.txt

ca14580

Co-authored-by: Marius Brehler <[email protected]>

Merge branch 'main' into users/dgaliffi/rocprof-sys-merged

8fe986e

geomin12 requested a review from HereThereBeDragons January 5, 2026 18:50

geomin12 reviewed Jan 5, 2026

View reviewed changes

Update dyninst CMakeLists.txt, added artifact-dyninst.toml

05a24c6

ScottTodd reviewed Jan 6, 2026

View reviewed changes

stellaraccident self-requested a review January 7, 2026 01:32

stellaraccident reviewed Jan 7, 2026

View reviewed changes

jbonnell-amd mentioned this pull request Jan 9, 2026

[Issue] Update TBB dependency for rocThrust #2837

Open

jbonnell-amd added 2 commits January 12, 2026 11:06

Add $PAR_JOBS to make command for binutils CMakeLists.txt

4c5fe52

Merge branch 'main' into users/dgaliffi/rocprof-sys-merged

9f7982f

subodh-dubey-amd force-pushed the main branch from 7e9ba03 to 3077ce8 Compare January 13, 2026 12:08

subodh-dubey-amd requested a review from a team as a code owner January 13, 2026 12:08

Merge branch 'main' into users/dgaliffi/rocprof-sys-merged

7c699cd

k-artem mentioned this pull request Jan 23, 2026

[Issue]: CI failed during fetching of 3rd party deps for rocprofiler-sdk #3068

Open

		"-DTHEROCK_BOOST_LIBRARIES=atomic,filesystem,multi_index,system"
		"-DTHEROCK_BOOST_LIBRARIES=atomic,chrono,date_time,filesystem,multi_index,system,thread,timer"

[rocprofiler-systems] Add third-party dependencies #2657

Are you sure you want to change the base?

[rocprofiler-systems] Add third-party dependencies #2657

Uh oh!

Conversation

jbonnell-amd commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

geomin12 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marbre commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jbonnell-amd commented Dec 19, 2025 •

edited

Loading