Skip to content

[rocBLAS] delete rocblas patch as develop modified with rocm_smi changes#2659

Closed
TorreZuk wants to merge 0 commit intomainfrom
users/torrezuk/patch-rm-mainline-003
Closed

[rocBLAS] delete rocblas patch as develop modified with rocm_smi changes#2659
TorreZuk wants to merge 0 commit intomainfrom
users/torrezuk/patch-rm-mainline-003

Conversation

@TorreZuk
Copy link

Motivation

Patch needs to be deleted to allow changes in rocm-libraries that avoid need for patch

Test Plan

How can this be atomic with other repo PR merge?
ROCm/rocm-libraries#3423

@ScottTodd
Copy link
Member

Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping land the patch. The sequence here will be:

  1. Revise ROCm/rocm-libraries#3423 to have rm ./TheRock/patches/amd-mainline/rocm-libraries/0003-Find-rocm_smi-via-config-files.patch in workflows then merge it
  2. When we next update the rocm-libraries submodule here in TheRock, we will delete the patch file (as this PR currently does, but together with the submodule update)
  3. When rocm-libraries next updates the ref for TheRock, the rm ./TheRock/patches/amd-mainline/rocm-libraries/0003-Find-rocm_smi-via-config-files.patch line can be removed

@jayhawk-commits
Copy link
Contributor

I will include this change in a rocm-libraries submodule bump I plan on doing on Friday.

@TorreZuk
Copy link
Author

Okay so should I get the other PR for patch removal in today as well?

@jayhawk-commits
Copy link
Contributor

Okay so should I get the other PR for patch removal in today as well?

This one? ROCm/rocm-libraries#3402

If that one lands in before Friday, I can remove both patches in that submodule bump I plan on doing that day.

@TorreZuk
Copy link
Author

@jayhawk-commits now it shows new failures (why did the PR pass then merge fail) I think this is what led to me reverting last time. Hopefully it can wait until Friday

@jayhawk-commits
Copy link
Contributor

Patch removed with #2752, this PR can be closed.

@TorreZuk TorreZuk closed this Jan 5, 2026
@TorreZuk TorreZuk force-pushed the users/torrezuk/patch-rm-mainline-003 branch from 3bdda76 to 3077ce8 Compare January 5, 2026 14:21
@github-project-automation github-project-automation bot moved this from TODO to Done in TheRock Triage Jan 5, 2026
@TorreZuk TorreZuk deleted the users/torrezuk/patch-rm-mainline-003 branch January 5, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants