[rocBLAS] delete rocblas patch as develop modified with rocm_smi changes#2659
[rocBLAS] delete rocblas patch as develop modified with rocm_smi changes#2659
Conversation
|
ScottTodd
left a comment
There was a problem hiding this comment.
Thanks for helping land the patch. The sequence here will be:
- Revise ROCm/rocm-libraries#3423 to have
rm ./TheRock/patches/amd-mainline/rocm-libraries/0003-Find-rocm_smi-via-config-files.patchin workflows then merge it - When we next update the rocm-libraries submodule here in TheRock, we will delete the patch file (as this PR currently does, but together with the submodule update)
- When rocm-libraries next updates the ref for TheRock, the
rm ./TheRock/patches/amd-mainline/rocm-libraries/0003-Find-rocm_smi-via-config-files.patchline can be removed
6acdc91 to
3bdda76
Compare
|
I will include this change in a rocm-libraries submodule bump I plan on doing on Friday. |
|
Okay so should I get the other PR for patch removal in today as well? |
This one? ROCm/rocm-libraries#3402 If that one lands in before Friday, I can remove both patches in that submodule bump I plan on doing that day. |
|
@jayhawk-commits now it shows new failures (why did the PR pass then merge fail) I think this is what led to me reverting last time. Hopefully it can wait until Friday |
|
Patch removed with #2752, this PR can be closed. |
3bdda76 to
3077ce8
Compare
Motivation
Patch needs to be deleted to allow changes in rocm-libraries that avoid need for patch
Test Plan
How can this be atomic with other repo PR merge?
ROCm/rocm-libraries#3423