Test: Revert Shared FileLock - 2nd Attempt #2702
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
FYI, tests can be done via workflow_dispatch (triggering for a particular architecture) rather than running the full build/test presubmit here! (runs for 3 architectures)! This way, CPU builders won't be used for 3 builds and tests can be done without a PR! |
geomin12
requested changes
Jan 2, 2026
Contributor
geomin12
left a comment
geomin12
left a comment
There was a problem hiding this comment.
let's close this PR and run tests with workflow_dispatch :) (https://github.com/ROCm/TheRock/actions/workflows/ci.yml)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update rocm-libraries submodule to de1285f
Test PR to get a build with rocm-libraries changes.
Attempt #2.