Standardize PROJECTS_TO_TEST environment variable to uppercase#3184
Merged
jayhawk-commits merged 3 commits intomainfrom Feb 2, 2026
Merged
Standardize PROJECTS_TO_TEST environment variable to uppercase#3184jayhawk-commits merged 3 commits intomainfrom
jayhawk-commits merged 3 commits intomainfrom
Conversation
Contributor
jayhawk-commits
commented
Jan 30, 2026
jayhawk-commits
commented
- environment variable names should be uppercase
- These variables will be consumed by the deduplication effort, see TheRock CI Deduplication Refactor #2960
ScottTodd
approved these changes
Jan 30, 2026
Member
ScottTodd
left a comment
ScottTodd
left a comment
There was a problem hiding this comment.
Are there any other uses in this repository? Should we be careful pulling this code into rocm-libraries and rocm-systems? I see uses there like https://github.com/ROCm/rocm-libraries/blob/e2555da2281e4f6d2560096f37487188e4e4e421/.github/workflows/therock-test-packages.yml#L54-L60
Comment on lines
+299
to
+301
| def run(): | ||
| platform = os.getenv("RUNNER_OS").lower() | ||
| project_to_test = os.getenv("project_to_test", "*") | ||
| project_to_test = os.getenv("PROJECT_TO_TEST", "*") |
Member
There was a problem hiding this comment.
Seems like this should be plural too? projects_to_test and PROJECTS_TO_TEST?
Contributor
Author
There was a problem hiding this comment.
Yes, should change to plural. There doesn't seem to be usage within TheRock repo currently. I will make the changes on the external repos with an update of their SHAs of TheRock.
- Doing changes individually in web browser while local workspace is used for other work in parallel.
- Doing changes individually in web browser while local workspace is used for other work in parallel.
Contributor
Author
|
I'll merge this on Monday, and update the super-repos accordingly. |
jayhawk-commits
deleted the
users/jayhawk-commits/pr/test-config-updates
branch
jayhawk-commits
changed the title
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.