Draft
Conversation
… into users/ibrahimw1/add-origami
Contributor
|
@ibrahimw1 looks like tests are still failing even when keeping PYTHONPATH, can you give it a look? |
Contributor
Author
PYTHONPATH only allows test_origami.py to pass, not rocm-sdk tests. The failing test is unrelated to my changes: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Re-land of origami TheRock CI integration (old/reverted PR: #2813).
The original PR was reverted because
origami.cpython-312-x86_64-linux-gnu.socouldn't findliborigami.so.1at runtime, causingrocm-sdk test(testSharedLibrariesLoad) to fail:This was due to two issues:
lib/directory whereliborigami.so.1is installedorigamiwas not registered in_dist_info.py, so the rocm-sdk packaging infrastructure didn't know about itWhat changed from the original PR
build_tools/packaging/python/templates/rocm/src/rocm_sdk/_dist_info.py: AddedLibraryEntry("origami", ...)so the rocm-sdk packaging properly tracksliborigami.so.rocm-libraries: shared/origami/python/CMakeLists.txt— AddedINSTALL_RPATHso the Python extension can findliborigami.so.1. Removed duplicate test install of.sofrombin/; the Python package inlib/pythonX.Y/site-packages/origami/is used for both regular use and testing.rocm-libraries: shared/origami/tests/CMakeLists.txt: Updated installedCTestTestfile.cmaketo setPYTHONPATHto thesite-packagesdirectory instead ofbin/origami/.build_tools/github_actions/test_executable_scripts/test_origami.py: UpdatedPYTHONPATHto point tolib/pythonX.Y/site-packages/where the origami package is installed.Original PR context
Add origami as a standalone TheRock subproject with CI testing integration. This enables independent testing of origami's C++ and Python components as part of TheRock's CI pipeline.
Files from original PR (unchanged)
math-libs/BLAS/CMakeLists.txt: Added Origami as a TheRock subproject with Catch2 test dependency and Python bindings enabledbuild_tools/github_actions/fetch_test_configurations.py: Added origami to test matrix with 5-minute timeout for Linux and WindowsTest Plan
rocm-sdk testpasses (testSharedLibrariesLoadno longer fails on origami.so)ctestfrom installedbin/origami/runs C++ and Python tests (locally)Submission Checklist