Skip to content

Skip incompatible rocprofiler-systems submodules on Windows. #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScottTodd merged 2 commits into from
Feb 13, 2025
Merged

Skip incompatible rocprofiler-systems submodules on Windows. #93

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8605b42
Skip incompatible rocprofiler-systems submodules on Windows.
ScottTodd Feb 14, 2025
d6832c7
Add links to upstream issues.
ScottTodd Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion build_tools/fetch_sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import argparse
import os
from pathlib import Path
import platform
import shlex
import shutil
import subprocess
Expand All @@ -17,6 +18,8 @@
DEFAULT_SOURCES_DIR = THEROCK_DIR / "sources"
PATCHES_DIR = THEROCK_DIR / "patches"

def is_windows() -> bool:
return platform.system() == "Windows"

def setup_repo_tool() -> Path:
"""Sets up https://gerrit.googlesource.com/git-repo/, downloading as needed."""
Expand Down Expand Up @@ -118,7 +121,14 @@ def populate_ancillary_sources(args):
step to fixing the underlying software packages."""
populate_submodules_if_exists(args.dir / "rocprofiler-register")
populate_submodules_if_exists(args.dir / "rocprofiler-sdk")
populate_submodules_if_exists(args.dir / "rocprofiler-systems")

# TODO(#36): Enable once rocprofiler-systems can be checked out on Windows
# error: invalid path 'src/counter_analysis_toolkit/scripts/sample_data/L2_RQSTS:ALL_DEMAND_REFERENCES.data.reads.stat'
# Upstream issues:
# https://github.com/ROCm/rocprofiler-systems/issues/105
# https://github.com/icl-utk-edu/papi/issues/321
if not is_windows():
populate_submodules_if_exists(args.dir / "rocprofiler-systems")


def populate_submodules_if_exists(git_dir: Path):
Expand Down