Skip to content

Conversation

@Micky774
Copy link
Contributor

Description

Please include a brief summary of the changes, relevant motivation and context.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@ipanfilo ipanfilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ck_fused_attn_bwd needs modification if the PR is for fwd-pass only?

@Micky774 Micky774 changed the title JAX FA Benchmarking Script (fwd-pass only) JAX FA Benchmarking Script Oct 31, 2025
@Micky774
Copy link
Contributor Author

Note that I have added the BWD pass implementation as well to this PR.

@Micky774 Micky774 requested a review from ipanfilo November 5, 2025 20:48
@Micky774
Copy link
Contributor Author

Pinging @wangye805 @wenchenvincent in case either of you are interested in reviewing this PR as well, thanks!

@Micky774 Micky774 self-assigned this Dec 1, 2025
@wenchenvincent
Copy link
Collaborator

Have you compared the kernel time measured from CK FA API vs from rocprof?

@wenchenvincent
Copy link
Collaborator

Have you compared the kernel time measured from CK FA API vs from rocprof?

@Micky774 Could you follow up? Let's try to close this PR soon.

@Micky774
Copy link
Contributor Author

@wenchenvincent just confirmed the timings reported match those recorded via rocprofv3. Anything else you'd like to see, or are we good to merge?

@Micky774 Micky774 merged commit 413b0ed into dev Jan 15, 2026
2 checks passed
@Micky774 Micky774 deleted the zain/jax-bench branch January 15, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants