Skip to content

Enable JAX distributed test for THD+Ring #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Micky774 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Enable JAX distributed test for THD+Ring #405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/jax/test_distributed_fused_attn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,6 @@ def impl_test_context_parallel_attn(
window_size=None,
):
if qkv_layout.is_thd():
if is_hip_extension() and cp_strategy == CPStrategy.RING:
pytest.skip("THD + ring on Rocm doesn't support context parallelism.")
if cp_strategy == CPStrategy.ALL_GATHER:
pytest.skip("THD doesn't support all gather context parallelism.")
if not load_balanced and cp_strategy == CPStrategy.RING:
Expand Down
Loading