[smoke-fort-fails] Add test for 'distribute parallel do if(...)' #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skatrak
requested review from
estewart08,
gregrodgers and
ronlieb
as code owners
dpalermo
requested changes
Mar 5, 2025
Contributor
dpalermo
left a comment
dpalermo
left a comment
There was a problem hiding this comment.
LGTM, but also add the test directory name to the smoke-fort-fails/Makefile TEST_DIR. This is to also allow running all tests with a 'make run' at the top level.
This test is currently causing a runtime failure related to some interaction between serial `teams` regions and `distribute parallel do` execution, triggered by `if` clauses attached to `parallel` evaluating to `false`. A potential fix to the issue is being proposed: llvm/llvm-project#129902.
skatrak
force-pushed
the
distribute-parallel-do-if-host
branch
from
cfb7136 to
f944e70
Compare
Member
Author
Thanks, done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is currently causing a runtime failure related to some interaction between serial
teamsregions anddistribute parallel doexecution, triggered byifclauses attached toparallelevaluating tofalse.A potential fix to the issue (which causes this test to pass) is being proposed: llvm/llvm-project#129902.