Skip to content

Potential fix for code scanning alert no. 5: Incorrect allocation-error handling #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rocm-devops wants to merge 3 commits into from
Closed

Potential fix for code scanning alert no. 5: Incorrect allocation-error handling #16

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ddb515
Potential fix for code scanning alert no. 5: Incorrect allocation-err…
bgopesh Jul 18, 2025
1e57066
Apply suggestion from @Copilot
bgopesh Jul 18, 2025
0118bae
Merge branch 'amd-staging' into alert-autofix-5
venkat1361 Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/util/hsa_rsrc_factory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,12 @@ HsaRsrcFactory::HsaRsrcFactory(bool initialize_hsa) : initialize_hsa_(initialize
CHECK_STATUS("loader API table query failed", status);

// Instantiate HSA timer
timer_ = new HsaTimer;
CHECK_STATUS("HSA timer allocation failed",
(timer_ == NULL) ? HSA_STATUS_ERROR : HSA_STATUS_SUCCESS);
timer_ = nullptr; // Ensure timer_ is initialized to nullptr
try {
timer_ = new HsaTimer;
} catch (const std::bad_alloc&) {
CHECK_STATUS("HSA timer allocation failed", HSA_STATUS_ERROR);
}

// System timeout
timeout_ =
Expand Down