Skip to content

[main] Add manylinux2_28 to wheel names #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[main] Add manylinux2_28 to wheel names #77

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d6076d5
Adding in changes from pytorch/pull/141988
ethanwee1 Apr 24, 2025
0801b48
Lint
ethanwee1 Apr 28, 2025
8e5dada
Lint
ethanwee1 Apr 28, 2025
f3f2004
lint
ethanwee1 Apr 29, 2025
30bec32
Try rename again
ethanwee1 May 30, 2025
6d03a15
Resolved comments
ethanwee1 Jun 9, 2025
d1eaa1c
Add manylinux_2_28_x86_64
ethanwee1 Jul 8, 2025
50ddb76
Update build_common.sh
ethanwee1 Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion manywheel/build_common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ SOURCE_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )"
# so manually do the work of copying dependency libs and patchelfing
# and fixing RECORDS entries correctly
######################################################################

PLATFORM="manylinux2014_x86_64"
fname_with_sha256() {
HASH=$(sha256sum $1 | cut -c1-8)
DIRNAME=$(dirname $1)
Expand Down Expand Up @@ -152,6 +152,11 @@ for pkg in /$WHEELHOUSE_DIR/torch_no_python*.whl /$WHEELHOUSE_DIR/${WHEELNAME_MA
$PATCHELF_BIN --set-rpath ${LIB_SO_RPATH:-'$ORIGIN'} ${FORCE_RPATH:-} $sofile
$PATCHELF_BIN --print-rpath $sofile
done
# create Manylinux 2_28 tag this needs to happen before regenerate the RECORD
if [[ $PLATFORM == "manylinux_2_28_x86_64" ]]; then
wheel_file=$(basename "$pkg" | sed -e 's/-cp.*$/.dist-info\/WHEEL/g')
sed -i -e s#linux_x86_64#"${PLATFORM}"# $wheel_file;
fi

# regenerate the RECORD file with new hashes
# record_file=$(echo $(basename $pkg) | sed -e 's/-cp.*$/.dist-info\/RECORD/g')
Expand Down Expand Up @@ -197,6 +202,15 @@ for pkg in /$WHEELHOUSE_DIR/torch_no_python*.whl /$WHEELHOUSE_DIR/${WHEELNAME_MA

popd
fi
# Rename wheel for Manylinux 2_28
if [[ $PLATFORM == "manylinux_2_28_x86_64" ]]; then
wheel_file=$(basename "$pkg" | sed -e 's/-cp.*$/.dist-info\/WHEEL/')
sed -i -e "s#linux_x86_64#${PLATFORM}#" "$wheel_file"
Copy link
Collaborator

@jithunnair-amd jithunnair-amd Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to go


zip -rq "$(basename "$pkg" | sed -e "s#linux_x86_64#${PLATFORM}#")" "${PREFIX}"*
Copy link
Collaborator

@jithunnair-amd jithunnair-amd Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternate idea: assign $pkg to $("$pkg" | sed -e "s#linux_x86_64#${PLATFORM}#") so that all the command after can keep referring to $pkg. Not sure if it messes with the iterator.

else
zip -rq "$(basename "$pkg")" "${PREFIX}"*
fi

# zip up the wheel back
zip -rq $(basename $pkg) $PREIX*
Copy link
Collaborator

@jithunnair-amd jithunnair-amd Jun 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to go

Also the lines below need to move into the if/else condition above:

    # replace original wheel
    rm -f $pkg
    mv $(basename $pkg) $pkg

Expand Down
1 change: 1 addition & 0 deletions manywheel/build_torch_wheel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ if [[ "$OS_NAME" == *"CentOS Linux"* ]]; then
retry yum install -q -y zip openssl
elif [[ "$OS_NAME" == *"AlmaLinux"* ]]; then
retry yum install -q -y zip openssl
PLATFORM="manylinux_2_28_x86_64"
elif [[ "$OS_NAME" == *"Red Hat Enterprise Linux"* ]]; then
retry dnf install -q -y zip openssl
elif [[ "$OS_NAME" == *"Ubuntu"* ]]; then
Expand Down
Loading