[Legacy-Flang][Driver][ASan] Add default rpath of host-asan #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ampandey-AMD
force-pushed
the
flang-driver-asan
branch
from
6ff62e6 to
0ebe32e
Compare
ronlieb
reviewed
Apr 4, 2024
Contributor
ronlieb
left a comment
ronlieb
left a comment
There was a problem hiding this comment.
LGTM, want @estewart08 to be final approver
Contributor
|
Cannot just always add |
Contributor
|
Add a condition to check if the |
library(libclang_rt.asan.x86_64.so)) for OpenMP Offloading applications when ASan.
ampandey-AMD
force-pushed
the
flang-driver-asan
branch
from
0ebe32e to
5d0641d
Compare
Author
Done. |
estewart08
reviewed
Apr 23, 2024
| // Add Fortran runtime libraries | ||
| if (needFortranLibs(D, Args)) { | ||
| ToolChain.AddFortranStdlibLibArgs(Args, CmdArgs); | ||
| CmdArgs.push_back("-rpath"); |
Contributor
There was a problem hiding this comment.
Does this need guarded with ! needsAsanRt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
library(libclang_rt.asan.x86_64.so)) for OpenMP Offloading applications when ASan.