EXSWHTEC-70 - Reimplement tests for hipMemPrefetchAsync#3004
Open
music-dino wants to merge 35 commits intoROCm:develop_oldfrom
Open
EXSWHTEC-70 - Reimplement tests for hipMemPrefetchAsync#3004music-dino wants to merge 35 commits intoROCm:develop_oldfrom
music-dino wants to merge 35 commits intoROCm:develop_oldfrom
Conversation
Contributor
music-dino
commented
Oct 17, 2022
music-dino
commented
- Negative parameter tests
- Validate that memory is usable on a device after prefetching to it
- Validate asynchronous behavior
- Validate round down for base address and roundup for base address + count behavior
…mmonly useful utility functions and kernels
…e supports any number of attributes
- Reimplement Unit_hipMemPrefetchAsync - Reimplement negative tests
- Implement additional negative tests - Implement tests for synchronization and rounding behavior
… for handling pitched memory
hipArrayCommon.hh.
chrispaquot
previously approved these changes
Oct 27, 2022
Contributor
|
@music-dino : PR fails on CI. Details shared separately. |
Contributor
Author
PR updated, please proceed with merge. |
mangupta
added
pr:ready_for_ci
chrispaquot
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.