Add description for ActivationType in Common.py#1189
Add description for ActivationType in Common.py#1189StaceyLai wants to merge 1 commit intoROCm:developfrom
Conversation
|
local CI pass: [----------] 1 test from ExtOpTest/ExtOpAMaxWithScaleUnsupportedDatatypeTest [----------] Global test environment tear-down -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html |
| # Activation | ||
| "Activation": False, | ||
| "ActivationNoGuard": False, | ||
| # ActivationType supports "none", "all" (10 activations) and "hipblaslt_all" (dgelu, gelu and relu). |
There was a problem hiding this comment.
ActivationType also support single activation except "none", "all" and "relu".
|
Please resolve merge conflicts or close this PR to complete the task of importing PRs from this repo to the monorepo. |
Add a description for ActivationType in common.py to help users be aware of the need to set this field.
ActivationType now supports "all", "hipblaslt_all" and "none". There are two reasons why it's not suitable to directly assign a default value to ActivationType now: 1. It's unclear whether the source is from Tensile or hipBLASLT; 2. It may cause a mismatch between the solution's config and the problemType.