Skip to content

hip_fp8.h doesn't exist before hip 6.2#1221

Open
m-kim wants to merge 1 commit intoROCm:developfrom
m-kim:hip_fp8_fix
Open

hip_fp8.h doesn't exist before hip 6.2#1221
m-kim wants to merge 1 commit intoROCm:developfrom
m-kim:hip_fp8_fix

Conversation

@m-kim
Copy link
Contributor

@m-kim m-kim commented Oct 10, 2024

To maintain backwards compatibility with versions of HIP prior to 6.2.

Should check before including.
@m-kim
Copy link
Contributor Author

m-kim commented Oct 10, 2024

I understand this might not be the best way to fix it, specifically that I check for the existence of OCP. I'm open to suggestions.

@m-kim m-kim requested review from cjatin and cmingch October 10, 2024 21:32
@cmingch
Copy link
Contributor

cmingch commented Oct 11, 2024

I understand this might not be the best way to fix it, specifically that I check for the existence of OCP. I'm open to suggestions.

i have similar PR #1072 before. due to i'm not sure if any one use hipblaslt with rocm less than 6.2, so PR has not been merged yet.

@eidenyoshida eidenyoshida added the noCI Disable testing on supported CI systems: math libraries CI has this feature enabled.. label May 15, 2025
@jayhawk-commits
Copy link
Contributor

Please resolve merge conflicts or close this PR to complete the task of importing PRs from this repo to the monorepo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

noCI Disable testing on supported CI systems: math libraries CI has this feature enabled..

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants