update changlog#2222
Open
jichangjichang wants to merge 1 commit intoROCm:release-staging/rocm-rel-7.0from
Open
update changlog#2222jichangjichang wants to merge 1 commit intoROCm:release-staging/rocm-rel-7.0from
jichangjichang wants to merge 1 commit intoROCm:release-staging/rocm-rel-7.0from
Conversation
jichangjichang
requested review from
a team,
Jinp800125,
KKyang,
Serge45,
TonyYHsieh,
aazz44ss,
hcman2,
imcarsonliao,
solaslin and
vin-huang
as code owners
amd-jnovotny
previously approved these changes
Jun 11, 2025
Contributor
amd-jnovotny
left a comment
amd-jnovotny
left a comment
There was a problem hiding this comment.
One minor rewording suggestion, but otherwise looks good.
CHANGELOG.md
Outdated
|
|
||
| ### Added | ||
|
|
||
| * Added``HIPBLASLT_MATMUL_DESC_A_SCALE_MODE`` and ``HIPBLASLT_MATMUL_DESC_B_SCALE_MODE`` attributes for setting scalar (``HIPBLASLT_MATMUL_MATRIX_SCALE_SCALAR_32F``), vector (``HIPBLASLT_MATMUL_MATRIX_SCALE_OUTER_VEC_32F``) or block (``HIPBLASLT_MATMUL_MATRIX_SCALE_VEC32_UE8M0``). |
Contributor
There was a problem hiding this comment.
Suggested change
| * Added``HIPBLASLT_MATMUL_DESC_A_SCALE_MODE`` and ``HIPBLASLT_MATMUL_DESC_B_SCALE_MODE`` attributes for setting scalar (``HIPBLASLT_MATMUL_MATRIX_SCALE_SCALAR_32F``), vector (``HIPBLASLT_MATMUL_MATRIX_SCALE_OUTER_VEC_32F``) or block (``HIPBLASLT_MATMUL_MATRIX_SCALE_VEC32_UE8M0``). | |
| * Added the ``HIPBLASLT_MATMUL_DESC_A_SCALE_MODE`` and ``HIPBLASLT_MATMUL_DESC_B_SCALE_MODE`` attributes for configuring (``HIPBLASLT_MATMUL_MATRIX_SCALE_SCALAR_32F``), vector (``HIPBLASLT_MATMUL_MATRIX_SCALE_OUTER_VEC_32F``), or block (``HIPBLASLT_MATMUL_MATRIX_SCALE_VEC32_UE8M0``) settings. |
jichangjichang
force-pushed
the
changelog_7.0
branch
from
ff81807 to
d7e2daf
Compare
amd-jnovotny
approved these changes
Jun 12, 2025
Contributor
|
this PR has merge conflicts and cannot be cleanly imported, please resolve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.