Merged
Conversation
github-actions
bot
added
in-progress
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ones method in the Iris framework to match PyTorch's ones API more closely. The changes improve parameter handling, documentation clarity, and tensor allocation behavior while maintaining compatibility with the Iris symmetric heap.
- Enhanced parameter processing for device, layout, and size handling
- Improved documentation with clearer parameter descriptions and formatting
- Added comprehensive test coverage for various edge cases and parameter combinations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| iris/iris.py | Updated ones method implementation with improved parameter handling, documentation, and tensor allocation logic |
| tests/unittests/test_ones.py | Added comprehensive test suite covering all ones method functionality, edge cases, and PyTorch API compatibility |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Match PyTorch
onesAPITechnical Details
Test Plan
Test Result
Submission Checklist