Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes performance by moving the num_xcds query outside of the matrix multiplication loop. The change hoists the iris.hip.get_num_xcc() call to class initialization time as a class variable, eliminating repeated HIP API calls during computation.
- Converts repeated
iris.hip.get_num_xcc()calls to a single class-level initialization - Updates all matmul wrapper implementations to use the cached value
- Minor import formatting improvement in one file
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/07_gemm_all_scatter/matmul_wrapper.py | Adds cached _num_xcds class variable and uses it instead of repeated API calls |
| examples/08_gemm_atomics_all_reduce/matmul_wrapper.py | Adds cached _num_xcds class variable and uses it instead of repeated API calls |
| examples/09_gemm_one_shot_all_reduce/matmul_wrapper.py | Adds cached _num_xcds class variable and uses it instead of repeated API calls |
| examples/10_gemm_all_scatter_wg_specialization/matmul_wrapper.py | Adds cached _num_xcds class variable, uses it instead of repeated API calls, and formats import statement |
| examples/11_gemm_all_scatter_producer_consumer/matmul_wrapper.py | Adds cached _num_xcds class variable and uses it instead of repeated API calls |
| examples/12_gemm_all_scatter_bulk_synchronous/matmul_wrapper.py | Adds cached _num_xcds class variable and uses it instead of repeated API calls |
neoblizz
approved these changes
Oct 9, 2025
Xinyu-Kang
pushed a commit
that referenced
this pull request
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Hoist
num_xcdsquery that goes through HIP APIs/ROCm version query outside of the matmul loop.Technical Details
This call is on the critical path of the benchmarking and we don't need to query that every loop. It drops the perf to 10s of TFLOPs with it in the loop.
Test Plan
Test Result
Submission Checklist