Merged
Conversation
github-actions
bot
added
in-progress
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Iris CI pipeline by adding Docker support alongside existing Apptainer functionality. The changes create universal container scripts that automatically detect and use either Docker or Apptainer runtime.
- Refactored CI workflows to use unified container scripts instead of hardcoded Apptainer commands
- Added universal container management scripts that support both Docker and Apptainer runtimes
- Simplified test execution by removing manual overlay image management and container binding
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/iris-tests-apptainer.yml | Updated to use universal container scripts and simplified test execution |
| .github/workflows/iris-performance-regression-test.yml | Refactored to use generic container build and execution scripts |
| .github/workflows/iris-external-validation-test.yml | Migrated from hardcoded Apptainer commands to universal container execution |
| .github/scripts/run_tests.sh | Enhanced test runner to accept GPU device parameters and use container execution |
| .github/scripts/run_perf_benchmark.sh | Refactored benchmark runner to use universal container execution approach |
| .github/scripts/container_run.sh | New universal script for running containers with either Docker or Apptainer |
| .github/scripts/container_exec.sh | New universal script for executing commands in containers with runtime detection |
| .github/scripts/container_build.sh | New universal script for building containers with automatic runtime detection |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist