Remove redundant tritonBLAS manual installations#372
Merged
Conversation
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove manual tritonBLAS install from scripts and yamls
Remove redundant tritonBLAS manual installations
Feb 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes all redundant manual tritonBLAS installations across the codebase, as tritonBLAS is now declared as a dependency in pyproject.toml (line 24). The changes ensure version consistency and reduce maintenance overhead by having a single source of truth for the tritonBLAS dependency.
Changes:
- Removed manual tritonBLAS clone and installation from Docker and Apptainer build processes
- Removed tritonBLAS installation checks and fallback logic from CI scripts
- Cleaned up TRITONBLAS_PATH environment variable references from Apptainer configuration
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docker/Dockerfile | Removed 7 lines of manual tritonBLAS clone and installation |
| apptainer/iris.def | Removed manual installation (7 lines), TRITONBLAS_PATH environment variable references (2 lines), and updated PYTHONPATH to exclude TRITONBLAS_PATH |
| .github/scripts/run_tests.sh | Removed 23 lines of tritonBLAS installation check and fallback logic |
| .github/scripts/run_perf_benchmark.sh | Removed 14 lines of manual tritonBLAS installation |
| .github/workflows/iris-external-validation-test.yml | Removed duplicate tritonBLAS installations from both external validation jobs (28 lines total) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tritonBLAS is already declared as a dependency in
pyproject.toml, making all manual installations redundant.Changes
TRITONBLAS_PATHenvironment variable (11 lines)Net: -81 lines across 5 files
tritonBLAS is now installed exclusively via
pip install iris, ensuring version consistency across all environments.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.