Add support for ROCm wheel based install #305
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires 0e599b747dbd3fc6 from rocm/xla This also requires some changes on the XLA side for the paths and such to have any effect. The plugin init now looks for a `rocm` python package install and extracts ROCm toolkit paths from the python packages that it finds. We hand these into the XLA portions of the plugin via environment variables to avoid changing any interfaces like protobuf or PJRT C APIs. We also have to patch the rpath in the shared object files included in the plugin and kernel wheels so they look relative to their install path just like the cuda based plugin objects do. Some other changes are fixing missing dynamic link libraries and also adding an optional feature target to pull in rocm python dependencies for the plugin. (cherry picked from commit 61b9046)
mrodden
force-pushed
the
rocm-wheels-0.4.35
branch
from
732af71 to
8afc41c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires 0e599b747dbd3fc6 from rocm/xla
This also requires some changes on the XLA side
for the paths and such to have any effect.
The plugin init now looks for a
rocmpythonpackage install and extracts ROCm toolkit paths
from the python packages that it finds. We hand
these into the XLA portions of the plugin via
environment variables to avoid changing any interfaces like protobuf or PJRT C APIs.
We also have to patch the rpath in the shared object files included in the plugin and kernel wheels so they look relative to their install path just like the cuda based plugin objects do.
Some other changes are fixing missing dynamic link libraries and also adding an optional feature target to pull in rocm python dependencies for the plugin.
(cherry picked from commit 61b9046)