Skip to content

Fix CI cleanup race condition #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix CI cleanup race condition #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/rocm-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,15 @@ jobs:
TEST_IMAGE: ubuntu-jax-${{ github.run_id }}_${{ github.run_number }}_${{ github.run_attempt }}
PYTHON_VERSION: ${{ matrix.python }}
ROCM_VERSION: ${{ matrix.rocm }}
WORKSPACE_DIR: workdir_${{ github.run_id }}_${{ github.run_number }}_${{ github.run_attempt }}
WORKSPACE_DIR: workdir_gpuci_${{ github.run_id }}_${{ github.run_number }}_${{ github.run_attempt }}
Copy link

@mrodden mrodden Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because we run two CI workflows on PR open?

steps:
- name: Clean up old runs
run: |
ls
# Make sure that we own all of the files so that we have permissions to delete them
docker run -v "./:/jax" ubuntu /bin/bash -c "chown -R $UID /jax/workdir_* || true"
docker run -v "./:/jax" ubuntu /bin/bash -c "chown -R $UID /jax/workdir_gpuci_* || true"
# Remove any old work directories from this machine
rm -rf workdir_*
rm -rf workdir_gpuci_*
ls
- name: Print system info
run: |
Expand Down
Loading