Skip to content

Conversation

@zahiqbal
Copy link

gfx950 platform support added

@JehandadKhan
Copy link
Collaborator

Please cherry pick to rocm-main

cc @gulsumgudukbay

@JehandadKhan JehandadKhan requested a review from mrodden April 24, 2025 19:17
@mrodden
Copy link

mrodden commented Apr 24, 2025

This isn't gonna compile until we have an updated compiler with the gfx950 target available I guess.

From the CI logs

clang++: error: invalid target ID 'gfx950'; format is a processor name followed by an optional colon-delimited list of features followed by an enable/disable sign (e.g., 'gfx908:sramecc+:xnack-')

@mrodden
Copy link

mrodden commented Apr 24, 2025

Also, I think we're gonna need the changes from XLA to support this, so we would need to update the XLA_COMMIT to point to something with the gfx950 support available in XLA.

Copy link

@mrodden mrodden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting a request changes on this until the XLA side is merged.

Changing the default targets to include 950 probably won't work until the ROCM 6.5 release anyway, so we'll have to find another way to allow internal builds to add that to targets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants