Skip to content

Fix the empty CSV result when run deprecated models #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coketaste wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix the empty CSV result when run deprecated models #37

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a3752f
The deprecated models will now be properly recorded in the performanc…
coketaste Sep 16, 2025
9c7a8b6
Update src/madengine/tools/run_models.py
coketaste Sep 17, 2025
3914ae6
Update src/madengine/tools/run_models.py
coketaste Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/madengine/tools/run_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,11 +923,18 @@ def run_model(self, model_info: typing.Dict) -> bool:
# Check if model is deprecated
if model_info.get("is_deprecated", False):
print(f"WARNING: Model {model_info['name']} has been deprecated.")
if self.args.ignore_deprecated_flag:
print(f"WARNING: Running deprecated model {model_info['name']} due to --ignore-deprecated-flag.")
else:
if not self.args.ignore_deprecated_flag:
print(f"WARNING: Skipping execution. No bypass flags mentioned.")
return True # exit early
print(f"Skipping model {model_info['name']} as it has been deprecated.")
# add result to output
self.return_status = True
run_details.status = "SKIPPED"
# generate performance entry for CSV update
run_details.generate_json("perf_entry.json")
update_perf_csv(exception_result="perf_entry.json", perf_csv=self.args.output)
return self.return_status # exit early
else:
print(f"WARNING: Running deprecated model {model_info['name']} due to --ignore-deprecated-flag.")

# check if model is supported on current gpu architecture, if not skip.
list_skip_gpu_arch = []
Expand Down