Fixing env variable for int8 calibration table #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedThemistokleous
approved these changes
Dec 2, 2025
TedThemistokleous
added
Bugfix
|
|
||
| if (int8_enable_ || fp8_enable_) { | ||
| int8_calibration_cache_available_ = !info.int8_calibration_table_name.empty(); | ||
| int8_calibration_cache_available_ = !int8_calibration_table_name_.empty(); |
Collaborator
There was a problem hiding this comment.
Check both flags with an || since user can take both paths with python, cpp api, and ENV variables
Author
There was a problem hiding this comment.
I kept the !int8_calibration_table_name_ variable, since it takes both cases in count. I've tested with setting environment variable and using provider_options ; both works with priority of ENV. I do not see the approach for simplifying more than this. What's your opinion and suggestion? @TedThemistokleous I think if this works; we should add this PR and put in backlog ticket if there is better way to do approach this.
TedThemistokleous
requested changes
Dec 2, 2025
Collaborator
TedThemistokleous
left a comment
TedThemistokleous
left a comment
There was a problem hiding this comment.
Change to use both flags.
TedThemistokleous
approved these changes
Dec 5, 2025
TedThemistokleous
merged commit a970a84
into
rocm7.2_internal_testing
9 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed when using MIGraphX environment variables inside scripts.
Previously, if we set:
os.environ["ORT_MIGRAPHX_INT8_CALIBRATION_TABLE_NAME"] = "calibration.flatbuffers"the int8_calibration_cache_available_ flag was not set correctly. We only encoded values from provider_options because we used info.int8_calibration_table_name, so the env var was ignored.