Skip to content

Conversation

@ethanwee1
Copy link

@ethanwee1 ethanwee1 commented Aug 19, 2025

Fixes https://ontrack-internal.amd.com/browse/SWDEV-541809
test runs:

root@rocm-framework-47:/var/lib/jenkins/pytorch/test# python test_monitor.py -m 'not serial' --shard-id=1 --num-shards=1 -v -vv -rfEX -p no:xdist --use-pytest -x --import-slow-tests --import-disabled-tests
/opt/venv/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py:1221: UserWarning: disabled test file provided but not found: .pytorch-disabled-tests.json
  warnings.warn(f'disabled test file provided but not found: {DISABLED_TESTS_FILE}')
============================================================================================ test session starts =============================================================================================
platform linux -- Python 3.10.12, pytest-7.3.2, pluggy-1.6.0 -- /opt/venv/bin/python
cachedir: .pytest_cache
hypothesis profile 'dev' -> database=None, max_examples=10, suppress_health_check=[HealthCheck.too_slow]
rootdir: /var/lib/jenkins/pytorch
configfile: pytest.ini
plugins: flakefinder-1.1.0, hypothesis-5.35.1, xdoctest-1.1.0, subtests-0.13.1, rerunfailures-14.0, cpp-2.3.0, xdist-3.3.1, typeguard-4.3.0
collected 6 items
Running 6 items in this shard

test_monitor.py::TestMonitor::test_event_handler PASSED [0.4558s]                                                                                                                                      [ 16%]
test_monitor.py::TestMonitor::test_fixed_count_stat PASSED [0.0029s]                                                                                                                                   [ 33%]
test_monitor.py::TestMonitor::test_interval_stat PASSED [0.0030s]                                                                                                                                      [ 50%]
test_monitor.py::TestMonitor::test_log_event PASSED [0.0019s]                                                                                                                                          [ 66%]
test_monitor.py::TestMonitor::test_wait_counter PASSED [0.0018s]                                                                                                                                       [ 83%]
test_monitor.py::TestMonitorTensorboard::test_event_handler PASSED [0.1933s]                                                                                                                           [100%]

============================================================================================= 6 passed in 0.70s ==============================================================================================
root@rocm-framework-47:/var/lib/jenkins/pytorch/test#

http://rocm-ci.amd.com/job/mainline-pytorch2.6-manylinux-wheels/254/

http://rocm-ci.amd.com/job/mainline-pytorch2.6-manylinux-wheels/255/

Cherry-picked to release/2.7 branch via #2537

Cherry-picked to release/2.8 branch via #2538

Cherry-picked to rocm7.1_internal_testing branch via #2539

@ethanwee1 ethanwee1 marked this pull request as ready for review August 19, 2025 18:36
@ethanwee1 ethanwee1 requested a review from jeffdaily as a code owner August 19, 2025 18:36
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Aug 19, 2025

Jenkins build for bcb2a72fff0b6c3a446b3a749ac1f7b3a634c0ed commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@jithunnair-amd
Copy link
Collaborator

@ethanwee1 Please make sure description of this PR matches the final changeset before requesting merge

@ethanwee1 ethanwee1 changed the title [release/2.6] Upgrade tensorboard [release/2.6] Remove tb-nightly Aug 19, 2025
@rocm-repo-management-api
Copy link

Jenkins build for bcb2a72fff0b6c3a446b3a749ac1f7b3a634c0ed commit is in progress
Links: Blue Ocean view / Build artifacts

@jithunnair-amd jithunnair-amd merged commit 2feede2 into release/2.6 Aug 19, 2025
0 of 2 checks passed
@jithunnair-amd jithunnair-amd deleted the release2.6_tensorboard branch August 19, 2025 19:58
@jithunnair-amd
Copy link
Collaborator

! cherry-pick --onto release/2.7 release/2.8 rocm7.1_internal_testing

@dhonnappa-amd
Copy link

Created branch autogenerated/release/2.7_cherry-pick_pr-2535 and #2537. It contains a merge conflict. Please resolve it

Created branch autogenerated/release/2.8_cherry-pick_pr-2535 and #2538. It contains a merge conflict. Please resolve it

Created branch autogenerated/rocm7.1_internal_testing_cherry-pick_pr-2535 and #2539. It contains a merge conflict. Please resolve it

Comment processed by Build

jithunnair-amd pushed a commit that referenced this pull request Aug 20, 2025
Cherry-pick of #2535

---------

Co-authored-by: Ethan Wee <[email protected]>
jithunnair-amd pushed a commit that referenced this pull request Aug 20, 2025
Cherry-pick of #2535

---------

Co-authored-by: Ethan Wee <[email protected]>
jithunnair-amd pushed a commit that referenced this pull request Aug 20, 2025
tvukovic-amd pushed a commit that referenced this pull request Aug 20, 2025
Cherry-pick of #2535

---------

Co-authored-by: Ethan Wee <[email protected]>
ethanwee1 added a commit that referenced this pull request Sep 10, 2025
Fixes https://ontrack-internal.amd.com/browse/SWDEV-541809
test runs:
```
root@rocm-framework-47:/var/lib/jenkins/pytorch/test# python test_monitor.py -m 'not serial' --shard-id=1 --num-shards=1 -v -vv -rfEX -p no:xdist --use-pytest -x --import-slow-tests --import-disabled-tests
/opt/venv/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py:1221: UserWarning: disabled test file provided but not found: .pytorch-disabled-tests.json
  warnings.warn(f'disabled test file provided but not found: {DISABLED_TESTS_FILE}')
============================================================================================ test session starts =============================================================================================
platform linux -- Python 3.10.12, pytest-7.3.2, pluggy-1.6.0 -- /opt/venv/bin/python
cachedir: .pytest_cache
hypothesis profile 'dev' -> database=None, max_examples=10, suppress_health_check=[HealthCheck.too_slow]
rootdir: /var/lib/jenkins/pytorch
configfile: pytest.ini
plugins: flakefinder-1.1.0, hypothesis-5.35.1, xdoctest-1.1.0, subtests-0.13.1, rerunfailures-14.0, cpp-2.3.0, xdist-3.3.1, typeguard-4.3.0
collected 6 items
Running 6 items in this shard

test_monitor.py::TestMonitor::test_event_handler PASSED [0.4558s]                                                                                                                                      [ 16%]
test_monitor.py::TestMonitor::test_fixed_count_stat PASSED [0.0029s]                                                                                                                                   [ 33%]
test_monitor.py::TestMonitor::test_interval_stat PASSED [0.0030s]                                                                                                                                      [ 50%]
test_monitor.py::TestMonitor::test_log_event PASSED [0.0019s]                                                                                                                                          [ 66%]
test_monitor.py::TestMonitor::test_wait_counter PASSED [0.0018s]                                                                                                                                       [ 83%]
test_monitor.py::TestMonitorTensorboard::test_event_handler PASSED [0.1933s]                                                                                                                           [100%]

============================================================================================= 6 passed in 0.70s ==============================================================================================
root@rocm-framework-47:/var/lib/jenkins/pytorch/test#

```

http://rocm-ci.amd.com/job/mainline-pytorch2.6-manylinux-wheels/254/

http://rocm-ci.amd.com/job/mainline-pytorch2.6-manylinux-wheels/255/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants