-
Notifications
You must be signed in to change notification settings - Fork 75
[AUTOGENERATED] rocm7.1_internal_testing_IFU_2025-09-24 #2678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
76a841f
46c647d
3016616
c91f59b
ce5637b
5780478
1708120
e0bcd58
1302637
32ad29b
0815091
ab5086a
33e6c5a
bee362c
264e7f6
f8f230a
e631d76
4967ad8
3e663ce
2984bfe
a3b68c7
607469b
a0d2d84
b8c5ec5
52dd7a8
03f34fd
bc7b17a
979e10f
a273475
4a160da
2a308c7
f8fb437
7130b17
ba3c2c8
466122b
e88460f
248156e
df9a482
9f8a311
fab8455
e6a9db5
9b5ec0f
0098e56
ee7bdd8
093f064
8225a26
bfe9e60
a1df0b4
a31acf3
e56dd5d
a87aea0
0b5a99b
df5d6d5
0ee331b
d55c9d5
5050cfa
eb11d17
f9074c7
d70c0ba
3938175
9e3725e
8e3fd3d
e37b600
2887f3f
97eb7a2
5b386ee
1ca9445
f591bb5
4a96a6f
1faf636
9ba9180
d8cbbc0
5d8a226
f34744d
51152ef
5599f48
4d3d32f
8b14f43
6ac2b3a
8a281d7
0b59492
01f927e
281bb56
3a7db34
f007894
ae5be03
edafc90
96a3afb
60b4791
9f5a644
10adeb9
509c4e8
eaac218
e310cc5
9ca183e
06fe5b9
5e7be98
281f8f4
d279a6a
bec967e
3be9c86
dd30667
4941719
7e97811
1818c36
eaa613b
bf28990
d150484
6f9aef5
d008670
fd785b1
e065d35
46e1b7d
cf28ab2
02da475
8abc2af
8e62d01
4027e97
09cb34c
e558f7a
da05aa7
0256f91
2b03663
7ea8998
36c2a13
a1bd924
c8fd2b4
4fc271e
e0cbab4
b756b58
60c2bde
33daaad
fa15fb0
8da0086
68e75be
539e84e
3ef1bef
2c7959e
8f30a8d
e9300b2
6a48f57
447b8fc
27164b6
0b75a16
95ac7d7
fcd79d5
0e12238
bb5be56
e3b392b
d3a1345
19b754d
08c5efd
d5e51d3
1545bb1
309fe03
45d9dcc
375f3e3
b426ba1
8d81564
5d749ce
3c64b2a
bda9ab2
1a42656
aff76c0
e05c9c0
4264fd3
518c320
ed84e80
9c4d9f9
6ef7487
49e7b2f
720a7b2
0f67407
b3cf5c7
5f0c7cb
ebddbe7
6e5dddb
221ac81
134dfbe
fde929c
2aadcea
649ceda
ca35dc2
0696a4b
8e6b0c7
bcb893a
22c5e8c
2a9745d
fc84743
e671dcc
5ca563e
b182365
8c8416b
29af258
c3d9f08
c63e417
b879ef7
2014908
6b5ad5f
f3f67ff
f9fa138
ee75c3d
eb3fbf5
4535254
dc93529
1e754d5
be6c127
e2ce79e
c261c71
ca512af
6fa9727
d746b98
42e9902
6f1d962
20eeb54
124dd36
0390798
a8e9ed2
f68de58
2c5a3d7
dad54ca
11a231e
bf0747c
0bca779
33aabdd
ec0cd81
6f34cc0
a635505
2390d34
3e1b1a3
207f104
b66aa1a
141fc72
3b73841
9d0d98a
5d0f639
4c2c401
9341ede
768361e
c414f75
0456b23
71eec6a
0dce2af
90a2825
1495b35
b40191b
f3e8213
0ad8381
63fcd9b
77f4534
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1 @@ | ||
| <<<<<<< HEAD | ||
| 6193b30becb1ac7be704cf87b8cb9bf13e7f9689 | ||
| ======= | ||
| bbb06c0334a6772b92d24bde54956e675c8c6604 | ||
| >>>>>>> upstream/main |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2924,7 +2924,7 @@ def _persistent_reduction_configs( | |
| for xblock in (1, 8, 32, 128) | ||
| if xblock == 1 or (xblock <= xnumel and (max_autotune_enabled or rnumel * xblock <= 4096)) | ||
| ] | ||
|
|
||
| if "y" not in size_hints: | ||
| configs = [ | ||
| triton_config_reduction( | ||
|
|
@@ -2958,17 +2958,6 @@ def _persistent_reduction_configs( | |
| # defer to more autotuning, initially | ||
| if "y" in size_hints: | ||
| pass | ||
| <<<<<<< HEAD | ||
|
|
||
| if not max_autotune_enabled: # Don't filter if tuning enabled | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jataylo to double-check this conflict resolution in case not already consulted
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Spoke to @naromero77amd, he mentioned that these changes went into rocm7.1_internal_testing but the upstream PR is still open. So, we want to keep rocm7.1_internal_testing changes in place. He pointed me to his upstream PR here: pytorch#163908 Tried to keep local changes but some of them were not trivial as Nick's PR upstream is with newer upstream. @naromero77amd / @jataylo can you please confirm that the latest commit I pushed corrects the merge of this file? |
||
| if reduction_hint == ReductionHint.INNER and rnumel >= 256: | ||
| configs = configs[:1] | ||
| elif reduction_hint == ReductionHint.OUTER: | ||
| configs = configs[-1:] | ||
|
|
||
| if reduction_hint == ReductionHint.OUTER_TINY: | ||
| tiny_configs = [ | ||
| ======= | ||
| # TODO(jansel): we should be able to improve these heuristics | ||
| elif reduction_hint == ReductionHint.INNER: | ||
| if rnumel > 1024: | ||
|
|
@@ -2995,7 +2984,6 @@ def _persistent_reduction_configs( | |
| configs = configs[-1:] | ||
| elif reduction_hint == ReductionHint.OUTER_TINY: | ||
| configs = [ | ||
| >>>>>>> upstream/main | ||
| triton_config_reduction( | ||
| size_hints, | ||
| 2 * (256 // rnumel) if rnumel <= 256 else 1, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -102,8 +102,8 @@ | |
| has_pytest = False | ||
|
|
||
|
|
||
| <<<<<<< HEAD | ||
| MI300_ARCH = ("gfx940", "gfx941", "gfx942") | ||
| MI200_ARCH = ("gfx90a") | ||
| NAVI_ARCH = ("gfx1030", "gfx1100", "gfx1101", "gfx1200", "gfx1201") | ||
| NAVI3_ARCH = ("gfx1100", "gfx1101") | ||
| NAVI4_ARCH = ("gfx1200", "gfx1201") | ||
|
|
@@ -115,10 +115,6 @@ def is_arch(arch_list): | |
| if gfx_arch in arch_list: | ||
| return True | ||
| return False | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @pragupta We should track the upstreaming of this patch in one of our stories. cc @iupaikov-amd |
||
| ======= | ||
| MI300_ARCH = ("gfx942",) | ||
| MI200_ARCH = ("gfx90a") | ||
| >>>>>>> upstream/main | ||
|
|
||
| def freeze_rng_state(*args, **kwargs): | ||
| return torch.testing._utils.freeze_rng_state(*args, **kwargs) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pragupta This change was supposed to be temporary as per f1ad49a (cc @pruthvistony)
Can we please ascertain if this is really needed for ROCm 7.1 mainline?
cc @jeffdaily to comment on whether this is needed for the ROCm7.0 CI upstream enablement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ROCm 7 CI upgrade doesn't have this line. What was this fixing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.